-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-20752: scanner-slim konflux onboarding #1429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: red-hat-konflux <rhtap@redhat.com>
Skipping CI for Draft Pull Request. |
1 task
msugakov
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux <rhtap@redhat.com> Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
msugakov
reviewed
Mar 12, 2024
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
msugakov
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How are
scanner-slim
pipelines different fromscanner
?->
scanner-slim
only fetchesrepo2cpe
and genesis manifests, scanner also fetches K8s & NVD definitions->
TARGET_STAGE
points to the respective stage in the DockerfileMulti-stage Docker build:
We have
builder-common
andscanner-common
stages. The finalscanner-slim
builds on just these two.For full scanner, in addition to
builder-common
andscanner-common
stages, there is a stage that unzips the K8s & NVD definitions, before all are combined in the final scanner stage.Validation
Looking at the images and confirming that slim does not have K8s & NVD definitions.
docker run -it --entrypoint /bin/sh quay.io/redhat-user-workloads/rh-acs-tenant/acs/scanner-slim:on-pr-1d4ab16dd540e4e82d44aededdbf6044f933e85f
docker run -it --entrypoint /bin/sh quay.io/redhat-user-workloads/rh-acs-tenant/acs/scanner:on-pr-1d4ab16dd540e4e82d44aededdbf6044f933e85f
Do the new pipelines match?
Do the slim and full pipelines match?