chore: add expiry label to images

[RTann]

See stackrox/stackrox#10385 for Scanner V4

[dcaravel]

Labels appear empty

docker inspect quay.io/stackrox-io/scanner-db-slim:2.33.x-13-gd0b3f1e261 | jq '.[].Config.Labels' | grep -E "version|release|quay"
  "io.buildah.version": "1.29.0",
  "quay.expires-after": "",
  "release": "",
  "version": ""

[RTann]

Labels appear empty

docker inspect quay.io/stackrox-io/scanner-db-slim:2.33.x-13-gd0b3f1e261 | jq '.[].Config.Labels' | grep -E "version|release|quay"
  "io.buildah.version": "1.29.0",
  "quay.expires-after": "",
  "release": "",
  "version": ""

apparently we don't use the make targets when building in CI. I'll look into it

[openshift-ci]

@RTann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	948fb35	link	false	/test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[RTann]

CI failure is unrelated

[porridge]

This look OK, but I wonder why we're duplicating the docker build command in the workflow definition? 🤔

[porridge]

Rather than expose this here, and duplicate the docker build command in the GHA yaml file, why not just call make scanner-image... in the GH action in the first place?
cc @BradLugo

[RTann]

I'm going to merge as-is, as this repo is more-or-less in maintenance mode, so I think this is ok