Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27485: Add comment not to delete source-location LABEL from Konflux Dockerfiles #1753

Merged

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen self-assigned this Jan 2, 2025
@tommartensen tommartensen requested a review from a team January 2, 2025 14:56
Copy link

openshift-ci bot commented Jan 2, 2025

@tommartensen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests fef4785 link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An optional suggestion, similar to stackrox/collector#2002 (review)

image/db/rhel/konflux.Dockerfile Outdated Show resolved Hide resolved
image/scanner/rhel/konflux.Dockerfile Outdated Show resolved Hide resolved
tommartensen and others added 2 commits January 3, 2025 09:28
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
@tommartensen tommartensen enabled auto-merge (squash) January 3, 2025 08:33
@tommartensen tommartensen merged commit 88111b5 into master Jan 3, 2025
22 of 25 checks passed
@tommartensen tommartensen deleted the tm/ROX-27485-konflux-do-not-delete-source-location branch January 3, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants