Skip to content

Commit

Permalink
Add terminationGracePeriodSeconds
Browse files Browse the repository at this point in the history
  • Loading branch information
@IneyMickey
IneyMickey committed Oct 24, 2023
1 parent 3e8defc commit 10bdc01
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 26 deletions.
53 changes: 27 additions & 26 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,32 +35,33 @@ To uninstall the chart:

### Deployment Paramaters

| Name | Description | Value |
|-------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------|----------------|
| deployment.enabled | Enable deployment on helm chart deployments | `true` |
| deployment.strategy | Strategy for updating deployments | `RollingUpdate` |
| deployment.reloadOnChange | Reload deployment if configMap/secret mounted are updated | `true` |
| deployment.nodeSelector | Select node to deploy this application | `{}` |
| deployment.hostAliases | Adding entries to a Pod's /etc/hosts file provides Pod-level override of hostname resolution when DNS and other options are not applicable | `[]` |
| deployment.additionalLabels | Additional labels for Deployment | `{}` |
| deployment.podLabels | Additional label added on pod which is used in Service's Label Selector | {} |
| deployment.annotations | Annotations on deployments | `{}` |
| deployment.additionalPodAnnotations | Additional Pod Annotations added on pod created by this Deployment | `{}` |
| deployment.replicas | Replicas to be created | `` |
| deployment.imagePullSecrets | Secrets used to pull image | `""` |
| deployment.env | Environment variables to be passed to the app container | `{}` |
| deployment.volumes | Volumes to be added to the pod | `{}` |
| deployment.volumeMounts | Mount path for Volumes | `{}` |
| deployment.revisionHistoryLimit | The number of old history to retain to allow rollback | `2` |
| deployment.command | Command for primary container of deployment | `[]` |
| deployment.args | Arg for primary container of deployment | `[]` |
| deployment.tolerations | Taint tolerations for nodes | `[]` |
| deployment.affinity | Affinity for pod/node | `[]` |
| deployment.topologySpreadConstraints| Topology spread constraints definitions | `[]` |
| deployment.ports | Ports for primary container | `[]` |
| deployment.securityContext | Security Context for the pod | `{}` |
| deployment.additionalContainers | Add additional containers besides init and app containers | `[]` |
| deployment.containerSecurityContext | Add security context at container level | `{}` |
| Name | Description | Value |
|------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------|----------------|
| deployment.enabled | Enable deployment on helm chart deployments | `true` |
| deployment.strategy | Strategy for updating deployments | `RollingUpdate` |
| deployment.reloadOnChange | Reload deployment if configMap/secret mounted are updated | `true` |
| deployment.nodeSelector | Select node to deploy this application | `{}` |
| deployment.hostAliases | Adding entries to a Pod's /etc/hosts file provides Pod-level override of hostname resolution when DNS and other options are not applicable | `[]` |
| deployment.additionalLabels | Additional labels for Deployment | `{}` |
| deployment.podLabels | Additional label added on pod which is used in Service's Label Selector | {} |
| deployment.annotations | Annotations on deployments | `{}` |
| deployment.additionalPodAnnotations | Additional Pod Annotations added on pod created by this Deployment | `{}` |
| deployment.replicas | Replicas to be created | `` |
| deployment.imagePullSecrets | Secrets used to pull image | `""` |
| deployment.env | Environment variables to be passed to the app container | `{}` |
| deployment.volumes | Volumes to be added to the pod | `{}` |
| deployment.volumeMounts | Mount path for Volumes | `{}` |
| deployment.revisionHistoryLimit | The number of old history to retain to allow rollback | `2` |
| deployment.command | Command for primary container of deployment | `[]` |
| deployment.args | Arg for primary container of deployment | `[]` |
| deployment.tolerations | Taint tolerations for nodes | `[]` |
| deployment.affinity | Affinity for pod/node | `[]` |
| deployment.topologySpreadConstraints | Topology spread constraints definitions | `[]` |
| deployment.ports | Ports for primary container | `[]` |
| deployment.securityContext | Security Context for the pod | `{}` |
| deployment.additionalContainers | Add additional containers besides init and app containers | `[]` |
| deployment.containerSecurityContext | Add security context at container level | `{}` |
| deployment.terminationGracePeriodSeconds | Graceful termination timeout | `` |

#### Deployment Resources Parameters

Expand Down
1 change: 1 addition & 0 deletions application/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -299,4 +299,5 @@ spec:
serviceAccountName: {{ template "application.name" $ }}
{{- end }}
{{- end }}
terminationGracePeriodSeconds: {{ .Values.deployment.terminationGracePeriodSeconds }}
{{- end }}
3 changes: 3 additions & 0 deletions application/values-test.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ deployment:
name: https
protocol: TCP

# Graceful termination timeout
terminationGracePeriodSeconds: 120

# Add Storage volumes to the pods
persistence:
enabled: true
Expand Down
3 changes: 3 additions & 0 deletions application/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,9 @@ deployment:
# name: https
# protocol: TCP

# Graceful termination timeout
terminationGracePeriodSeconds:

##########################################################
# Add Storage volumes to the pods
##########################################################
Expand Down

0 comments on commit 10bdc01

Please sign in to comment.