Skip to content

Commit

Permalink
fix clusterIP null field (#295)
Browse files Browse the repository at this point in the history
Co-authored-by: Zadkiel Aharonian <zadkiel.aharonian@gmail.com>
  • Loading branch information
jdcmarques and aslafy-z authored Jan 12, 2024
1 parent a869898 commit a194946
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

All notable changes to this project will be documented here.

### v2.3.2
- Feature: fix clusterIP null field introduced by [PR-275](https://github.com/stakater/application/pull/275) [PR-295](https://github.com/stakater/application/pull/295)

### v2.3.1
- Feature: Allow loadbalancer service external IP [PR-275](https://github.com/stakater/application/pull/275)
- Feature: Allowing HPA behavior to be set [PR-292](https://github.com/stakater/application/pull/292)
Expand Down
4 changes: 3 additions & 1 deletion application/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
clusterIP: {{ .Values.service.clusterIP }}
{{- with .Values.service.clusterIP }}
clusterIP: {{ . }}
{{- end }}
{{- if eq .Values.service.type "LoadBalancer" }}
{{- with .Values.service.loadBalancerIP }}
loadBalancerIP: {{ . }}
Expand Down

0 comments on commit a194946

Please sign in to comment.