Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of "set flag" in cmdstan-guide #808

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

katrinabrock
Copy link
Contributor

Submission Checklist

  • Builds locally
  • [N/A] New functions marked with <<{ since VERSION }>>
  • Declare copyright holder and open-source license: see below

Summary

State explicitly that setting STAN_THREADS, STAN_MPI, and STAN_OPENCL to any value, including falsy values, turns the corresponding feature on.

Fix stan-dev/cmdstan#1293

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

State explicitly that setting `STAN_THREADS`, `STAN_MPI`,
and `STAN_OPENCL` to any value, including falsy values,
turns the corresponding feature on.

Fix stan-dev/cmdstan#1293
@WardBrian
Copy link
Member

I think "defined" is slightly more correct than "set", but this is already an improvement so I would be happy to merge it

@katrinabrock
Copy link
Contributor Author

@WardBrian done

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WardBrian WardBrian merged commit 9a6b9fb into stan-dev:master Aug 21, 2024
@katrinabrock katrinabrock deleted the fix-cmdstan-1293 branch August 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc Fix? Setting STAN_THREADS=false (or FALSE, 0, etc) results in STAN_THREADS=true
2 participants