Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: v3 (plugins and monorepo support) #3

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

tunnckoCore
Copy link
Member

Support for #1 monorepos, and #2 plugins.

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #3 into master will increase coverage by 9.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   63.63%   72.72%   +9.09%     
==========================================
  Files           1        1              
  Lines          11       11              
==========================================
+ Hits            7        8       +1     
+ Misses          4        3       -1
Impacted Files Coverage Δ
src/index.js 72.72% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7254d1d...3b58f32. Read the comment docs.

@tunnckoCore tunnckoCore changed the title major: v3 major: v3 (plugins and monorepo support) Feb 1, 2019
@tunnckoCore
Copy link
Member Author

tunnckoCore commented Feb 18, 2019

ref: conventional-commits/conventionalcommits.org#118 (comment)

Do not support mono-repo setups. Lerna is doing great.

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jun 24, 2019

Yet, we may create lerna plugin, so we can use it under the hood, just like the npm one.

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jun 24, 2019

The workflow basically will be

  1. If normal repo: activate the Github APP and install the CLI
  2. If monorepo: deactivate (or non activating it at all) GitHub APP and use the lerna plugin for the CLI (e.g. standard-release --plugin lerna) which will also create github releases (so requires the GH_TOKEN env in CI). It will also use lerna changed under the hood.

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jun 24, 2019

The npm plugin (default) should also support dist-tag flag.
The lerna plugin should also support the dist-tag. Basically use dargs to pass all coming flags to lerna

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jun 24, 2019

  • Make --dry-run alias for the --dry flag.
  • Rename --token to --npm-token and --gh-token / --github-token
  • Mirror & sync from env the GH_TOKEN (lerna required, for gh releases) and GITHUB_TOKEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant