Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use boto3 Multipart transfers #4022

Merged
merged 2 commits into from
Apr 9, 2024
Merged

use boto3 Multipart transfers #4022

merged 2 commits into from
Apr 9, 2024

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Apr 4, 2024

…ation/api/latest/guide/s3.html

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (1133f67) to head (b037573).
Report is 2 commits behind head on master.

❗ Current head b037573 differs from pull request most recent head a872c8f. Consider uploading reports for the commit a872c8f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4022      +/-   ##
==========================================
- Coverage   54.82%   54.62%   -0.19%     
==========================================
  Files         640      640              
  Lines       70982    70982              
==========================================
- Hits        38908    38770     -138     
- Misses      32074    32212     +138     
Flag Coverage Δ
unittests 54.62% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5027c...a872c8f. Read the comment docs.

Copy link

github-actions bot commented Apr 8, 2024

Benchmark for 82703d3

Click to view benchmark
Test Base PR %
accumulator_append 846.6±165.05µs 991.4±214.59µs +17.10%
block_apply/block_apply_10 649.8±26.93ms 671.2±46.93ms +3.29%
block_apply/block_apply_1000 76.5±2.34s 76.7±1.79s +0.26%
get_with_proof/db_store 59.5±14.66µs 55.2±8.57µs -7.23%
get_with_proof/mem_store 42.1±2.71µs 58.8±12.00µs +39.67%
put_and_commit/db_store/1 130.1±19.08µs 160.5±31.67µs +23.37%
put_and_commit/db_store/10 1181.1±75.52µs 1304.8±166.46µs +10.47%
put_and_commit/db_store/100 10.6±1.04ms 12.6±2.24ms +18.87%
put_and_commit/db_store/5 633.4±121.92µs 659.4±127.02µs +4.10%
put_and_commit/db_store/50 5.4±0.33ms 5.8±0.60ms +7.41%
put_and_commit/mem_store/1 78.7±7.64µs 88.3±18.16µs +12.20%
put_and_commit/mem_store/10 720.6±56.61µs 811.7±138.30µs +12.64%
put_and_commit/mem_store/100 7.8±0.88ms 9.0±1.63ms +15.38%
put_and_commit/mem_store/5 386.4±33.01µs 443.0±88.56µs +14.65%
put_and_commit/mem_store/50 5.1±1.63ms 3.8±0.36ms -25.49%
query_block/query_block_in(10)_times(100) 6.1±0.59ms 6.0±0.57ms -1.64%
query_block/query_block_in(10)_times(1000) 60.3±3.53ms 67.5±6.28ms +11.94%
query_block/query_block_in(10)_times(10000) 589.2±19.62ms 623.6±58.83ms +5.84%
query_block/query_block_in(1000)_times(100) 1402.0±153.33µs 1506.1±58.69µs +7.43%
query_block/query_block_in(1000)_times(1000) 13.4±0.82ms 15.9±2.02ms +18.66%
query_block/query_block_in(1000)_times(10000) 129.6±1.77ms 157.1±17.94ms +21.22%
storage_transaction 1049.6±363.46µs 1160.8±459.54µs +10.59%
vm/transaction_execution/1 805.7±70.82ms 803.8±49.26ms -0.24%
vm/transaction_execution/10 203.4±10.31ms 208.5±22.53ms +2.51%
vm/transaction_execution/20 198.7±24.22ms 190.8±11.52ms -3.98%
vm/transaction_execution/5 261.1±11.41ms 304.9±41.34ms +16.78%
vm/transaction_execution/50 212.4±16.55ms 215.2±18.06ms +1.32%

@jackzhhuang jackzhhuang enabled auto-merge (squash) April 9, 2024 02:48
@jackzhhuang jackzhhuang merged commit ffa7362 into master Apr 9, 2024
5 checks passed
@jackzhhuang jackzhhuang deleted the update_script branch April 9, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants