Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test_force_upgrade_1 #4363

Merged
merged 1 commit into from
Dec 27, 2024
Merged

update test_force_upgrade_1 #4363

merged 1 commit into from
Dec 27, 2024

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao requested review from welbon and nkysg December 27, 2024 02:45
Copy link

coderabbitai bot commented Dec 27, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@nkysg nkysg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Benchmark for e37bdc9

Click to view benchmark
Test Base PR %
accumulator_append 794.4±108.12µs 1081.4±236.28µs +36.13%
block_apply/block_apply_10 682.4±108.19ms 516.0±15.87ms -24.38%
block_apply/block_apply_1000 64.7±2.73s 64.1±3.45s -0.93%
get_with_proof/db_store 48.1±3.51µs 50.8±6.13µs +5.61%
get_with_proof/mem_store 38.6±3.10µs 42.1±7.40µs +9.07%
put_and_commit/db_store/1 119.8±6.19µs 143.5±24.23µs +19.78%
put_and_commit/db_store/10 1145.8±69.33µs 1245.5±191.68µs +8.70%
put_and_commit/db_store/100 10.1±1.14ms 12.3±2.38ms +21.78%
put_and_commit/db_store/5 557.0±31.38µs 638.4±82.61µs +14.61%
put_and_commit/db_store/50 5.3±0.32ms 6.2±1.29ms +16.98%
put_and_commit/mem_store/1 84.8±16.73µs 103.3±18.63µs +21.82%
put_and_commit/mem_store/10 723.9±120.81µs 991.3±165.65µs +36.94%
put_and_commit/mem_store/100 7.2±1.14ms 7.7±1.06ms +6.94%
put_and_commit/mem_store/5 348.9±35.85µs 410.8±91.90µs +17.74%
put_and_commit/mem_store/50 3.5±0.46ms 3.6±0.44ms +2.86%
query_block/query_block_in(10)_times(100) 4.7±0.53ms 6.0±0.89ms +27.66%
query_block/query_block_in(10)_times(1000) 49.3±5.84ms 48.7±6.85ms -1.22%
query_block/query_block_in(10)_times(10000) 443.3±14.45ms 522.2±54.92ms +17.80%
query_block/query_block_in(1000)_times(100) 1280.9±69.72µs 1227.4±123.30µs -4.18%
query_block/query_block_in(1000)_times(1000) 13.7±1.44ms 13.2±2.07ms -3.65%
query_block/query_block_in(1000)_times(10000) 121.5±6.68ms 129.6±8.24ms +6.67%
storage_transaction 1160.3±445.96µs 1090.0±372.36µs -6.06%
vm/transaction_execution/1 580.3±27.83ms 624.2±44.67ms +7.57%
vm/transaction_execution/10 155.9±9.67ms 173.6±13.62ms +11.35%
vm/transaction_execution/20 153.2±17.41ms 154.3±22.72ms +0.72%
vm/transaction_execution/5 213.1±15.55ms 215.6±12.85ms +1.17%
vm/transaction_execution/50 160.0±8.42ms 166.5±7.23ms +4.06%

@simonjiao simonjiao merged commit c311d7a into master Dec 27, 2024
5 checks passed
@simonjiao simonjiao deleted the update-test-force-upgrade-1 branch December 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants