This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
refac: add Starknet-devnet-rs #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @estheroche . Thanks for your contribution. The idea is to add a new section to the Starknet Book with starkli x Rust-devnet. We still want to keep the starkli x Katana section. |
gianalarcon
reviewed
Mar 4, 2024
src/ch02-02-01-Starknet-devnet-rs.md
Outdated
|
|
||
| ```console | ||
| rustc --version #1.73.0 (cc66ad468) | ||
| Scarb --version # 2.5.0 (c531a6e50) |
There was a problem hiding this comment.
Can we work with the latest version of scarb and starkli?
src/ch02-02-01-Starknet-devnet-rs.md
Outdated
|
|
||
| ```toml | ||
| [dependencies] | ||
| starknet = ">=2.3.0" |
There was a problem hiding this comment.
Can we work with the latest version of starknet? 2.5.4
src/ch02-02-01-Starknet-devnet-rs.md
Outdated
| self.name.write(name); | ||
| } | ||
|
|
||
| #[external(v0)] |
There was a problem hiding this comment.
I think we have to replace #[external(v0)] with something new
There was a problem hiding this comment.
can we replace with this #[abi(embed_v0)] ?
|
alright.
…On Tue, Mar 5, 2024 at 8:29 AM GianMarco ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ch02-02-01-Starknet-devnet-rs.md
<#339 (comment)>
:
> +Begin with the `src/lib.cairo` file, which provides a foundational template. Remove its contents and insert the following:
+
+```rust
+#[starknet::contract]
+mod hello {
+ #[storage]
+ struct Storage {
+ name: felt252,
+ }
+
+ #[constructor]
+ fn constructor(ref self: ContractState, name: felt252) {
+ self.name.write(name);
+ }
+
+ #[external(v0)]
yes
—
Reply to this email directly, view it on GitHub
<#339 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A532767PSBZQ63GEWP44ZXLYWXJEXAVCNFSM6AAAAABEDZR7NKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJXGE4DGNZRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
gianalarcon
reviewed
Mar 6, 2024
src/ch02-02-01-Starknet-devnet-rs.md
Outdated
|
|
||
| Begin with the `src/lib.cairo` file, which provides a foundational template. Remove its contents and insert the following: | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
Smart contract code is not complete
src/ch02-02-starkli-scarb-katana.md
Outdated
| @@ -49,7 +49,7 @@ Amend the `Scarb.toml` file to integrate the `starknet` dependency and introduce | |||
|
|
|||
| ```toml | |||
| [dependencies] | |||
| starknet = ">=2.3.0" | |||
| starknet = ">=2.5.4" | |||
There was a problem hiding this comment.
We should not change this file
gianalarcon
reviewed
Mar 7, 2024
src/ch02-02-01-Starknet-devnet-rs.md
Outdated
| You can install the latest [scarb](#https://docs.swmansion.com/scarb/download.html) version. | ||
|
|
||
| ```console | ||
| rustc --version #1.73.0 (cc66ad468) |
There was a problem hiding this comment.
Here we should check starknet-devnet version. Not rust language version
|
Fixed!
…On Thu, Mar 7, 2024 at 10:04 AM GianMarco ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ch02-02-01-Starknet-devnet-rs.md
<#339 (comment)>
:
> +
+| Account address | 0x49f78b29f6eee314a6c297f7a2f943a0c93dc4ec2c8f3c2089c05f351d0660b
+| Private key | 0x94de45f28d52b5808ef42bd8e5261f90
+| Public key | 0x5c7f51e81c5d1770201f6ef31e46fed058b10322478f4f1d57ae4c542a5d60e
+
+Predeployed accounts using class with hash: 0x61dac032f228abef9c6626f995015233097ae253a7f72d68552db02f2971b8f
+Initial balance of each account: 1000000000000000000000 WEI and FRI
+Seed to replicate this account sequence: 534956567
+
+## Crafting a Starknet Smart Contract
+
+**Important:** Before we proceed with this example, please ensure that the versions of both `Scarb` and `starkli` match the specified versions provided below.
+You can install the latest [scarb](#https://docs.swmansion.com/scarb/download.html) version.
+
+```console
+ rustc --version #1.73.0 (cc66ad468)
Here we should check starknet-devnet version. Not rust language version
—
Reply to this email directly, view it on GitHub
<#339 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A532762OVP55Z44WLELMGHLYXCFZTAVCNFSM6AAAAABEDZR7NKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRSHA3TGMZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
gianalarcon
approved these changes
Mar 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #324