Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the saving of datasets to include exception handling #443

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Changed the saving of datasets to include exception handling #443

merged 1 commit into from
Nov 19, 2024

Conversation

Jorgen-5
Copy link
Contributor

@Jorgen-5 Jorgen-5 commented Nov 19, 2024 •
edited
Loading

  • When a dataset is not open and the save button I pressed -> ValueError
  • When a dataset is open but the it is not able to be saved -> FileNotFoundError
  • Added error message in the UI if the file is not able to be saved

@Jorgen-5 Jorgen-5 requested a review from a team as a code owner November 19, 2024 08:32
mmwinther
mmwinther approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice one 🙌

@Jorgen-5 Jorgen-5 merged commit 45566ac into master Nov 19, 2024
18 checks passed
@Jorgen-5 Jorgen-5 deleted the update-exceptions branch November 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmwinther mmwinther mmwinther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorgen-5 @mmwinther