-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename nimbus binary to nimbus_execution_client #2728
Conversation
Kurtosis check is breaking, as it keeps waiting for the CL to sync I am working with the ethpandaops to fix this, till then not to worry about the kurtosis check |
8cb4ea7
to
3e2eb86
Compare
This pr only addresses the binary name as identified in #2258. We could go further and rename the source directory from nimbus to nimbus_execution_client , however all files history under nimbus directory won't be easily accessible via git log command, only via git log --follow. Would like to get some opinions regarding if we are confortable with the directory renaming, or I can open a follow up issue to think/discuss about it about it |
Fluffy failure is a flaky test due to a recent change. Can be ignored here. |
Seems fine to leave the directory as-is for now. Can be discussed in a separate issue or PR. |
Renaming nimbus binary to nimbus_execution_client in order to free the "nimbus" binary name. addresses issue #2258
Directory renaming will be addressed in a different issue (#2738)