Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nimbus binary to nimbus_execution_client #2728

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

pedromiguelmiranda
Copy link
Contributor

@pedromiguelmiranda pedromiguelmiranda commented Oct 10, 2024

Renaming nimbus binary to nimbus_execution_client in order to free the "nimbus" binary name. addresses issue #2258

Directory renaming will be addressed in a different issue (#2738)

@advaita-saha
Copy link
Contributor

Kurtosis check is breaking, as it keeps waiting for the CL to sync
Issue happened after ethpandaops/ethereum-package#804

I am working with the ethpandaops to fix this, till then not to worry about the kurtosis check

Makefile Outdated Show resolved Hide resolved
@pedromiguelmiranda pedromiguelmiranda marked this pull request as ready for review October 14, 2024 15:15
@pedromiguelmiranda
Copy link
Contributor Author

This pr only addresses the binary name as identified in #2258.

We could go further and rename the source directory from nimbus to nimbus_execution_client , however all files history under nimbus directory won't be easily accessible via git log command, only via git log --follow.

Would like to get some opinions regarding if we are confortable with the directory renaming, or I can open a follow up issue to think/discuss about it about it

@kdeme
Copy link
Contributor

kdeme commented Oct 14, 2024

Fluffy failure is a flaky test due to a recent change. Can be ignored here.

@tersec
Copy link
Contributor

tersec commented Oct 14, 2024

This pr only addresses the binary name as identified in #2258.

We could go further and rename the source directory from nimbus to nimbus_execution_client , however all files history under nimbus directory won't be easily accessible via git log command, only via git log --follow.

Would like to get some opinions regarding if we are confortable with the directory renaming, or I can open a follow up issue to think/discuss about it about it

Seems fine to leave the directory as-is for now. Can be discussed in a separate issue or PR.

@tersec tersec merged commit bc0f1ba into master Oct 15, 2024
28 checks passed
@tersec tersec deleted the dev/pedro/rn_bin branch October 15, 2024 09:37
yakimant added a commit to status-im/infra-role-nimbus-eth1 that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants