Beacon sync revisting fc automove base #2961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: This is basically a tweaked version of Andri's function `importBlockBlindly()` from the draft PR mentioned above.
why: Not needed anymore, `forkChoice()` as has been integrated into `importBlock()`.
mjfh
force-pushed
the
Beacon-sync-revisting-fc-automove-base
branch
from
23e1bbb to
c9667f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for the beacon syncer running without knowledge of a finalised header.
The
FCmodule part using a modifiedimportBlock()function has been adapted from PR #2845 (fc-automove-base).The automatic finaliser part of
importBlock()needs to be double checked for compliance. But it will be invalidated anyway by the upcoming PR #2960 (forked-layers) and so needs to be rewritten.The beacon sync part of this PR works well and there should be no functionality updates necessary regarding the usage of the modified
importBlock()function.