prepare builder API, modify electra BuilderBid

[agnxsh]

No description provided.

[github-actions]

Unit Test Results

       15 files  ±0    2 285 suites  ±0   1h 6m 51s ⏱️ + 1m 39s
  5 368 tests ±0    5 021 ✔️ ±0  347 💤 ±0  0 ❌ ±0 
37 069 runs  ±0  36 579 ✔️ ±0  490 💤 ±0  0 ❌ ±0 

Results for commit 1f44f89. ± Comparison against base commit 5547d2a.

♻️ This comment has been updated with latest results.

[tersec]

Run excluded_files="config.yaml|config.nims|beacon_chain.nimble"
The following files do not have an up-to-date copyright year:
- beacon_chain/spec/mev/electra_mev.nim
- beacon_chain/spec/mev/fulu_mev.nim
Error: Process completed with exit code 2.

[tersec]

The comment at

nimbus-eth2/beacon_chain/spec/state_transition.nim

Line 538 in 4d89d95

debugComment "verify (again) that this is what builder API needs"

is addressed by this PR and should be removed.

[tersec]

The electra_mev.BlindedExecutionPayloadAndBlobsBundle and fulu_mev.BlindedExecutionPayloadAndBlobsBundle cases are identical and can be combined.

[tersec]

Also, in general whenever nimbus-eth2 has these

  when cond1:
    ...
  elif cond2:
    ...
  elif cond3:
    ...

conditions, it adds on an

  else:
    static: doAssert false

or

  else:
    static: raiseAssert "..."

e.g.

nimbus-eth2/beacon_chain/spec/state_transition_epoch.nim

Lines 1016 to 1037 in 4e44027

	when consensusFork <= ConsensusFork.Deneb:
	let penalty_numerator = validator.effective_balance div increment *
	adjusted_total_slashing_balance
	penalty_numerator div total_balance * increment
	elif consensusFork == ConsensusFork.Electra:
	let
	effective_balance_increments = validator.effective_balance div increment
	penalty_per_effective_balance_increment =
	adjusted_total_slashing_balance div (total_balance div increment)
	# [Modified in Electra:EIP7251]
	penalty_per_effective_balance_increment * effective_balance_increments
	elif consensusFork == ConsensusFork.Fulu:
	let
	effective_balance_increments = validator.effective_balance div increment
	penalty_per_effective_balance_increment =
	adjusted_total_slashing_balance div (total_balance div increment)
	# [Modified in Electra:EIP7251]
	penalty_per_effective_balance_increment * effective_balance_increments
	else:
	static: doAssert false

That it's static: ... is important; the exact way it causes the compilation to fail is less important. This way, if/when the conditions fail to hold -- e.g., here, a new fork is added after Fulu -- it won't silently stop working, but rather loudly fail to compile.

[agnxsh]

resolved in 90ece63

[tersec]

Same issues as https://github.com/status-im/nimbus-eth2/pull/6872/files#r1929864463

[agnxsh]

resolved in 90ece63

[tersec]

this debugComment is addressed by this PR, can be removed

[agnxsh]

resolved in 90ece63