Onboarding flows: SB page improvements, timeouts removal and other minor fixes #17048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
caybro
reviewed
Jan 10, 2025
micieslak
force-pushed
the
feat/issue-17030-17031-17032
branch
from
015bf15 to
a2c3aa3
Compare
@caybro I addressed your comments and added one more commit (externalizing metrics, as you suggested in the comment in code). Please take a look once again. |
caybro
approved these changes
Jan 10, 2025
| "usage_data_shared", | ||
| { placement: Constants.metricsEnablePlacement.onboarding }) | ||
| localAppSettings.metricsPopupSeen = true | ||
| } |
There was a problem hiding this comment.
Good move imo; this is mainly for @jrainville, I guess you'll want to handle this signal yourself from now in main.qml
|
|
||
| readonly property alias stack: stack | ||
|
|
||
| signal shareUsageDataRequested(bool enabled) |
There was a problem hiding this comment.
This is the one to hook into @jrainville
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes: #17030
Closes: #17031
Closes: #17032
Affected areas
Onboarding flows
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)