Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: handle missing columns 'connector_enabled' and 'log_namespaces' #6248

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jan 13, 2025

This PR will prevent significant database pollution when older mobile users (e.g., v1.10.1) upgrade to v2.30.0.

for details pls see the comment

@qfrank qfrank self-assigned this Jan 13, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 13, 2025

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 907df1f #1 2025-01-13 08:14:46 ~4 min tests 📄log
✔️ 907df1f #1 2025-01-13 08:15:10 ~4 min windows 📦zip
✔️ 907df1f #1 2025-01-13 08:15:46 ~5 min ios 📦zip
✔️ 907df1f #1 2025-01-13 08:15:52 ~5 min linux 📦zip
✔️ 907df1f #1 2025-01-13 08:15:59 ~5 min macos 📦zip
✔️ 907df1f #1 2025-01-13 08:16:09 ~5 min macos 📦zip
✔️ 907df1f #1 2025-01-13 08:16:39 ~6 min android 📦aar
✔️ 907df1f #1 2025-01-13 08:17:01 ~6 min tests-rpc 📄log
✔️ 3975e62 #2 2025-01-13 09:09:36 ~2 min windows 📦zip
✖️ 3975e62 #2 2025-01-13 09:10:49 ~4 min tests 📄log
✔️ 3975e62 #2 2025-01-13 09:11:56 ~5 min ios 📦zip
✔️ 3975e62 #2 2025-01-13 09:12:03 ~5 min macos 📦zip
✔️ 3975e62 #2 2025-01-13 09:12:03 ~5 min linux 📦zip
✔️ 3975e62 #2 2025-01-13 09:12:14 ~5 min macos 📦zip
✔️ 3975e62 #2 2025-01-13 09:12:43 ~6 min android 📦aar
✔️ 3975e62 #2 2025-01-13 09:13:37 ~6 min tests-rpc 📄log
✔️ 60fec46 #3 2025-01-14 03:33:08 ~3 min windows 📦zip
✔️ 60fec46 #3 2025-01-14 03:33:19 ~3 min macos 📦zip
✔️ 60fec46 #3 2025-01-14 03:33:38 ~4 min ios 📦zip
✔️ 60fec46 #3 2025-01-14 03:35:04 ~5 min macos 📦zip
✔️ 60fec46 #3 2025-01-14 03:35:06 ~5 min linux 📦zip
✔️ 60fec46 #3 2025-01-14 03:35:22 ~5 min android 📦aar
✖️ 60fec46 #3 2025-01-14 03:38:24 ~8 min tests 📄log
✔️ 60fec46 #3 2025-01-14 03:41:29 ~11 min tests-rpc 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ beedab2 #4 2025-01-14 03:53:11 ~3 min windows 📦zip
✔️ beedab2 #4 2025-01-14 03:53:41 ~3 min macos 📦zip
✔️ beedab2 #4 2025-01-14 03:53:48 ~3 min ios 📦zip
✔️ beedab2 #4 2025-01-14 03:54:59 ~4 min linux 📦zip
✔️ beedab2 #4 2025-01-14 03:55:29 ~5 min macos 📦zip
✔️ beedab2 #4 2025-01-14 03:55:34 ~5 min android 📦aar
✔️ beedab2 #4 2025-01-14 04:00:46 ~10 min tests-rpc 📄log
✔️ beedab2 #4 2025-01-14 04:24:47 ~34 min tests 📄log
✔️ 45d97be #5 2025-01-21 11:09:34 ~4 min ios 📦zip
✔️ 45d97be #5 2025-01-21 11:10:38 ~5 min linux 📦zip
✔️ 45d97be #5 2025-01-21 11:10:48 ~5 min macos 📦zip
✔️ 45d97be #5 2025-01-21 11:10:54 ~5 min windows 📦zip
✔️ 45d97be #5 2025-01-21 11:10:55 ~5 min android 📦aar
✔️ 45d97be #5 2025-01-21 11:11:24 ~5 min tests-rpc 📄log
✔️ 45d97be #5 2025-01-21 11:12:00 ~6 min macos 📦zip
✖️ 45d97be #5 2025-01-21 11:24:19 ~18 min tests 📄log
✔️ 45d97be #6 2025-01-21 11:55:45 ~27 min tests 📄log

nodecfg/node_config.go Show resolved Hide resolved
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.79%. Comparing base (b2bb680) to head (45d97be).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6248      +/-   ##
===========================================
+ Coverage    61.74%   61.79%   +0.04%     
===========================================
  Files          845      845              
  Lines       111323   111336      +13     
===========================================
+ Hits         68739    68797      +58     
+ Misses       34612    34572      -40     
+ Partials      7972     7967       -5     
Flag Coverage Δ
functional 21.48% <82.85%> (+0.02%) ⬆️
unit 60.32% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appdatabase/database.go 70.65% <100.00%> (+0.10%) ⬆️
nodecfg/node_config.go 70.08% <100.00%> (+4.26%) ⬆️

... and 29 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants