feat(onboarding)_: add a notification when importing old account #6255
+297
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
4 tasks
jrainville
force-pushed
the
feat/new-onboarding-fetching-notification
branch
from
cc655fc to
4ed5c9a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6255 +/- ##
===========================================
+ Coverage 61.84% 61.90% +0.06%
===========================================
Files 843 843
Lines 111287 111368 +81
===========================================
+ Hits 68824 68942 +118
+ Misses 34497 34467 -30
+ Partials 7966 7959 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jrainville
force-pushed
the
feat/new-onbaording
branch
from
e446e61 to
cf3c5ca
Compare
jrainville
force-pushed
the
feat/new-onboarding-fetching-notification
branch
from
4ed5c9a to
b8a3d32
Compare
Needed for status-im/status-desktop#17028 When a user imports an old account, we start fetching the backups. Now, we show an activity center notification to let the user know, because the onboarding doesn't block during the fetching anymore, so it happens in the background. After a timeout, the notification turns into a failure state (full or partial). The user can then restart the fetching. I added a test to validate the logic of calculating if the fetching was a success. That logic used to be in Nim.
jrainville
force-pushed
the
feat/new-onboarding-fetching-notification
branch
from
b8a3d32 to
746cb48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-desktop#17028
When a user imports an old account, we start fetching the backups. Now, we show an activity center notification to let the user know, because the onboarding doesn't block during the fetching anymore, so it happens in the background.
After a timeout, the notification turns into a failure state (full or partial). The user can then restart the fetching.
I added a test to validate the logic of calculating if the fetching was a success. That logic used to be in Nim.