chore(wallet)_: include l1 fees info (for the tx and approval) in the response #6271

saledjenic · 2025-01-20T10:34:30Z

A while ago we disabled l1 info cause the estimated L1 fees were significantly higher than they should have been (if I remember well, the L1 fees were about 1000 times higher than they should have been).

From this point, that wrong value might be coming from unreliable pokt calls/values, these changes bring them back.

saledjenic · 2025-01-20T10:35:41Z

Initiative for this PR is coming from this comment status-im/status-mobile#21876 (comment)

status-im-auto · 2025-01-20T10:38:45Z

Jenkins Builds

Click to see older builds (19)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`67b8da3`	#1	2025-01-20 10:38:45	~3 min	`ios`	📦`zip`
✔️	`67b8da3`	#1	2025-01-20 10:40:17	~5 min	`linux`	📦`zip`
✔️	`67b8da3`	#1	2025-01-20 10:40:27	~5 min	`macos`	📦`zip`
✔️	`67b8da3`	#1	2025-01-20 10:40:36	~5 min	`android`	📦`aar`
✔️	`67b8da3`	#1	2025-01-20 10:40:45	~5 min	`macos`	📦`zip`
✖️	`67b8da3`	#1	2025-01-20 10:40:49	~5 min	`tests-rpc`	📄`log`
✔️	`67b8da3`	#1	2025-01-20 10:41:04	~6 min	`windows`	📦`zip`
✖️	`67b8da3`	#1	2025-01-20 11:05:34	~30 min	`tests`	📄`log`

✔️	`214e425`	#2	2025-01-23 18:27:23	~5 min	`ios`	📦`zip`
✔️	`214e425`	#2	2025-01-23 18:59:37	~6 min	`android`	📦`aar`
✖️	`214e425`	#2	2025-01-23 21:33:14	~31 min	`tests`	📄`log`
✖️	`214e425`	#2	2025-01-23 23:20:05	~5 min	`tests-rpc`	📄`log`
✔️	`214e425`	#2	2025-01-24 10:47:51	~5 min	`linux`	📦`zip`
✔️	`214e425`	#2	2025-01-24 11:21:03	~5 min	`macos`	📦`zip`
✔️	`214e425`	#2	2025-01-24 11:26:09	~7 min	`macos`	📦`zip`
✔️	`214e425`	#2	2025-01-24 13:05:48	~7 min	`windows`	📦`zip`
✖️	`214e425`	#3	2025-01-24 13:05:58	~3 min	`tests-rpc`	📄`log`
✖️	`214e425`	#4	2025-01-24 13:23:57	~3 min	`tests-rpc`	📄`log`
✖️	`214e425`	#3	2025-01-24 13:49:36	~29 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`39ed123`	#3	2025-01-24 13:43:59	~3 min	`macos`	📦`zip`
✔️	`39ed123`	#3	2025-01-24 13:44:15	~4 min	`ios`	📦`zip`
✔️	`39ed123`	#3	2025-01-24 13:44:45	~4 min	`windows`	📦`zip`
✔️	`39ed123`	#3	2025-01-24 13:45:30	~5 min	`macos`	📦`zip`
✔️	`39ed123`	#3	2025-01-24 13:45:36	~5 min	`linux`	📦`zip`
✔️	`39ed123`	#3	2025-01-24 13:45:43	~5 min	`android`	📦`aar`
✖️	`39ed123`	#5	2025-01-24 13:45:52	~5 min	`tests-rpc`	📄`log`
✖️	`39ed123`	#4	2025-01-24 14:20:19	~30 min	`tests`	📄`log`

✔️	`3a81b49`	#4	2025-01-24 15:12:49	~3 min	`ios`	📦`zip`
✔️	`3a81b49`	#4	2025-01-24 15:12:58	~3 min	`macos`	📦`zip`
✔️	`3a81b49`	#4	2025-01-24 15:13:17	~4 min	`windows`	📦`zip`
✔️	`3a81b49`	#4	2025-01-24 15:14:26	~5 min	`macos`	📦`zip`
✔️	`3a81b49`	#4	2025-01-24 15:14:37	~5 min	`linux`	📦`zip`
✖️	`3a81b49`	#6	2025-01-24 15:14:38	~5 min	`tests-rpc`	📄`log`
✔️	`3a81b49`	#4	2025-01-24 15:14:47	~5 min	`android`	📦`aar`
✔️	`3a81b49`	#5	2025-01-24 15:40:09	~31 min	`tests`	📄`log`

alaibe

Have u confirmed the value makes sense?

saledjenic · 2025-01-21T14:33:51Z

Have u confirmed the value makes sense?

I did not. Expect people from the mobile team to check and respond to that.

pavloburykh · 2025-01-22T15:57:28Z

@saledjenic thank you for the PR. Could you please check the ISSUE 1 identified in corresponding mobile PR?

saledjenic · 2025-01-23T14:30:02Z

@pavloburykh could you try again now?

dlipicar

changes look good, waiting for confirmation that the values actually make sense

pavloburykh · 2025-01-23T16:06:11Z

@pavloburykh could you try again now?

thank you @saledjenic! @VolodLytvynenko will be able to pick it up tomorrow, as I will be off. Also, I see some builds failed in this PR, is it related to changes of some infra issues?

saledjenic · 2025-01-23T16:10:47Z

is it related to changes of some infra issues?

Should not be up to the changes here, something must be stuck, will push again later and see.

codecov · 2025-01-24T13:07:34Z

Codecov Report

Attention: Patch coverage is 55.88235% with 30 lines in your changes missing coverage. Please review.

Project coverage is 61.40%. Comparing base (e71fdbc) to head (3a81b49).

Files with missing lines	Patch %	Lines
services/wallet/router/router.go	50.00%	7 Missing and 1 partial ⚠️
services/wallet/router/router_helper.go	79.31%	5 Missing and 1 partial ⚠️
services/wallet/router/routes/router_path.go	0.00%	4 Missing and 2 partials ⚠️
...vices/wallet/transfer/transaction_manager_route.go	0.00%	2 Missing ⚠️
...let/router/pathprocessor/processor_bridge_celar.go	0.00%	1 Missing ⚠️
...allet/router/pathprocessor/processor_bridge_hop.go	75.00%	1 Missing ⚠️
...t/router/pathprocessor/processor_ens_public_key.go	0.00%	1 Missing ⚠️
...let/router/pathprocessor/processor_ens_register.go	0.00%	1 Missing ⚠️
...llet/router/pathprocessor/processor_ens_release.go	0.00%	1 Missing ⚠️
...s/wallet/router/pathprocessor/processor_erc1155.go	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6271      +/-   ##
===========================================
- Coverage    61.84%   61.40%   -0.45%     
===========================================
  Files          843      843              
  Lines       111287   111255      -32     
===========================================
- Hits         68824    68312     -512     
- Misses       34497    35025     +528     
+ Partials      7966     7918      -48

Flag	Coverage Δ
functional	`20.46% <33.82%> (-1.09%)`	⬇️
unit	`60.35% <45.58%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...et/router/pathprocessor/processor_swap_paraswap.go	`48.73% <100.00%> (+1.01%)`	⬆️
.../wallet/router/pathprocessor/processor_transfer.go	`56.92% <100.00%> (-0.66%)`	⬇️
...let/router/pathprocessor/processor_bridge_celar.go	`0.00% <0.00%> (ø)`
...allet/router/pathprocessor/processor_bridge_hop.go	`11.82% <75.00%> (+0.64%)`	⬆️
...t/router/pathprocessor/processor_ens_public_key.go	`15.51% <0.00%> (+0.76%)`	⬆️
...let/router/pathprocessor/processor_ens_register.go	`12.16% <0.00%> (+0.47%)`	⬆️
...llet/router/pathprocessor/processor_ens_release.go	`15.51% <0.00%> (+0.76%)`	⬆️
...s/wallet/router/pathprocessor/processor_erc1155.go	`4.49% <0.00%> (+0.14%)`	⬆️
...es/wallet/router/pathprocessor/processor_erc721.go	`3.27% <0.00%> (+0.07%)`	⬆️
...let/router/pathprocessor/processor_stickers_buy.go	`11.94% <0.00%> (+0.51%)`	⬆️
... and 4 more

... and 47 files with indirect coverage changes

saledjenic · 2025-01-24T13:53:29Z

@antdanchenko could you please help on this, cause functional tests must be failing due to missing OVM_GasPriceOracle contract on Anvil?

… response While ago we've disabled l1 info cause the estimated L1 fees were significantly higher than they should have been (if I remember well, the L1 fees were about 1000 times higher than they should have been). From this point, that wrong value might be coming from unreliable pokt calls/values, these changes bring them back.

saledjenic requested review from alaibe, friofry, dlipicar and briansztamfater January 20, 2025 10:34

saledjenic mentioned this pull request Jan 20, 2025

feat: integrate base chain status-im/status-mobile#21876

Merged

8 tasks

pavloburykh mentioned this pull request Jan 20, 2025

Test status go PR 6271 status-im/status-mobile#21963

Open

alaibe reviewed Jan 21, 2025

View reviewed changes

saledjenic force-pushed the chore/include-l1-fees branch from 67b8da3 to 214e425 Compare January 23, 2025 14:28

alaibe approved these changes Jan 23, 2025

View reviewed changes

dlipicar approved these changes Jan 23, 2025

View reviewed changes

saledjenic force-pushed the chore/include-l1-fees branch from 214e425 to 39ed123 Compare January 24, 2025 13:39

saledjenic force-pushed the chore/include-l1-fees branch from 39ed123 to 3a81b49 Compare January 24, 2025 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(wallet)_: include l1 fees info (for the tx and approval) in the response #6271

chore(wallet)_: include l1 fees info (for the tx and approval) in the response #6271

saledjenic commented Jan 20, 2025

saledjenic commented Jan 20, 2025

status-im-auto commented Jan 20, 2025 •

edited

Loading

alaibe left a comment

saledjenic commented Jan 21, 2025

pavloburykh commented Jan 22, 2025

saledjenic commented Jan 23, 2025

dlipicar left a comment

pavloburykh commented Jan 23, 2025

saledjenic commented Jan 23, 2025

codecov bot commented Jan 24, 2025 •

edited

Loading

saledjenic commented Jan 24, 2025

chore(wallet)_: include l1 fees info (for the tx and approval) in the response #6271

Are you sure you want to change the base?

chore(wallet)_: include l1 fees info (for the tx and approval) in the response #6271

Conversation

saledjenic commented Jan 20, 2025

saledjenic commented Jan 20, 2025

status-im-auto commented Jan 20, 2025 • edited Loading

Jenkins Builds

alaibe left a comment

Choose a reason for hiding this comment

saledjenic commented Jan 21, 2025

pavloburykh commented Jan 22, 2025

saledjenic commented Jan 23, 2025

dlipicar left a comment

Choose a reason for hiding this comment

pavloburykh commented Jan 23, 2025

saledjenic commented Jan 23, 2025

codecov bot commented Jan 24, 2025 • edited Loading

Codecov Report

saledjenic commented Jan 24, 2025

status-im-auto commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 24, 2025 •

edited

Loading