-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The FROM page is shown when user goes to send flow using scanner #20878
Comments
This flow was disabled in the past: #20972 |
IMO would be better to reintroduce it only after the new send flow implementation. The current flow creates some edge-case issues, that's why it was disabled |
@VolodLytvynenko What should I do with this issue then? Keep it in the blocked state? |
@alwx I tried to find issues, but it seems this is the only one issue. Apologies, it looks like you can proceed with this. Sending assets via QR would indeed be useful. Thank you for pointing it hi @shivekkhurana Do we need to reintroduce it now? |
I'll remove this from the milestone, because it will be rather not valid after simplification send flow |
It's unclear whether the issue is resolved in the new send flow. The navigation was removed in PR #20979, so perhaps we should consider re-enabling it and retest to confirm if this is resolved after the new send flow merging. I think this is a useful feature. @churik Should I add it back to the milestone? |
up to @shivekkhurana As for me I do not think this one has a hight priority |
Fixed in #21899 as it's the same flow from saved addresses |
Follow up for #20773
Precondition:
User has only one account
Steps:
Actual result:
User sees the 'account 1' in from page
sendflow.mp4
Expected result:
The user is navigated directly to the send flow page if user has only 1 account and uses scanner during send flow
ENV:
Nightly 25 Jul 2024
The text was updated successfully, but these errors were encountered: