Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The FROM page is shown when user goes to send flow using scanner #20878

Open
VolodLytvynenko opened this issue Jul 25, 2024 · 8 comments · May be fixed by #21899
Open

The FROM page is shown when user goes to send flow using scanner #20878

VolodLytvynenko opened this issue Jul 25, 2024 · 8 comments · May be fixed by #21899
Labels
wallet-core Issues for mobile wallet team

Comments

@VolodLytvynenko
Copy link
Contributor

Follow up for #20773

Precondition:

User has only one account

Steps:

  1. Goes to scanner -> scan the wallet QR

Actual result:

User sees the 'account 1' in from page

sendflow.mp4

Expected result:

The user is navigated directly to the send flow page if user has only 1 account and uses scanner during send flow

ENV:

Nightly 25 Jul 2024

@VolodLytvynenko VolodLytvynenko added 🔢 low prio bug wallet-core Issues for mobile wallet team labels Jul 25, 2024
@shivekkhurana shivekkhurana added this to the 2.31.0 Beta milestone Oct 3, 2024
@alwx alwx self-assigned this Oct 4, 2024
@alwx alwx removed the low-prio label Oct 4, 2024
@churik churik added the low-prio label Oct 9, 2024
@churik churik modified the milestones: 2.31.0 Beta, 2.32.0 Beta Oct 9, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
@alwx alwx added the blocked label Oct 22, 2024
@alwx
Copy link
Contributor

alwx commented Oct 22, 2024

This flow was disabled in the past: #20972
Do we need to reintroduce it?

@shivekkhurana

@VolodLytvynenko
Copy link
Contributor Author

This flow was disabled in the past: #20972 Do we need to reintroduce it?

@shivekkhurana

IMO would be better to reintroduce it only after the new send flow implementation. The current flow creates some edge-case issues, that's why it was disabled

@alwx
Copy link
Contributor

alwx commented Oct 23, 2024

@VolodLytvynenko What should I do with this issue then? Keep it in the blocked state?
Could you point me out to the issue/epic/whatever about the new send flow implementation?

@VolodLytvynenko
Copy link
Contributor Author

@alwx I tried to find issues, but it seems this is the only one issue. Apologies, it looks like you can proceed with this. Sending assets via QR would indeed be useful. Thank you for pointing it

hi @shivekkhurana Do we need to reintroduce it now?

@churik churik removed the low-prio label Nov 25, 2024
@churik
Copy link
Member

churik commented Nov 25, 2024

I'll remove this from the milestone, because it will be rather not valid after simplification send flow

cc @shivekkhurana

@churik churik unassigned alwx Nov 25, 2024
@churik churik removed this from the 2.32.0 milestone Nov 25, 2024
@VolodLytvynenko
Copy link
Contributor Author

It's unclear whether the issue is resolved in the new send flow. The navigation was removed in PR #20979, so perhaps we should consider re-enabling it and retest to confirm if this is resolved after the new send flow merging. I think this is a useful feature.

@churik Should I add it back to the milestone?

@churik churik removed the blocked label Dec 26, 2024
@churik
Copy link
Member

churik commented Dec 26, 2024

up to @shivekkhurana

As for me I do not think this one has a hight priority

@smohamedjavid
Copy link
Member

Fixed in #21899 as it's the same flow from saved addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet-core Issues for mobile wallet team
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants