fix(wallet)_: Send flow from saved address and QR scanner #21899
+91
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
commented
Jan 8, 2025
Comment on lines
+151
to
+155
| (rf/reg-event-fx | ||
| :wallet/init-send-flow-for-address | ||
| (fn [_ [args]] | ||
| {:fx [[:dispatch [:wallet/clean-send-data]] | ||
| [:dispatch [:wallet/open-send-flow args]]]})) |
There was a problem hiding this comment.
We clean the send data before user goes into the flow. This ensure no data from any other flows is left and also to prevent any bugs.
smohamedjavid
commented
Jan 8, 2025
Comment on lines
+64
to
+69
| :header [quo/page-nav | ||
| {:type :no-title | ||
| :icon-name :i/close | ||
| :on-press events-helper/navigate-back | ||
| :margin-top (safe-area/get-top) | ||
| :background :blur}]} |
There was a problem hiding this comment.
We don't need account switcher on the from page
smohamedjavid
requested review from
alwx,
shivekkhurana,
vkjr,
briansztamfater,
clauxx and
mohsen-ghafouri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21898
fixes #20878
Summary
This PR:
Single.Account.mp4
Two.Accounts.mp4
QR.Scanner.mp4
Testing notes
A quick test of the send flow from the Wallet tab is appreciated
Platforms
Steps to test
From Saved Addresses
Profile > Wallet > Saved AddressesSend to <SAVED_ADDRESS_NAME>From) page if the user has more than one operable accountsFrom QR Scanner
[-]) on the profile navigation headerFrom) page if the user has more than one operable accountsstatus: ready