[Android] "Failed to migrate key pair" screen in the end of Migration flow with upgraded user from v1

[mariia-skrypnyk]

Bug Report

Actual behavior

V1 user with NO keycard did such upgrade:

1.20.5
2.30
2.31
2.32

Did a login and after he tried to migrate his key to the Keycard and he get this screen at the end of Migration flow

After tap on Logout & Remove Profile we see Login screen with our migrated user (Keycard icon is present).
User can login with his keycard and sign transactions.

I was testing on Android only as upgrade tests could only be tested there.

Logs: Error_migration.zip

Reproduction

1. Install 1.20.5 https://ci.infra.status.im/job/status-mobile/job/release/job/release%252F1.20.x/
2. Create User
3. Install 2.32 https://ci.infra.status.im/job/status-mobile/job/release/job/release%252F2.32.x/
4. Login -> Profile -> Keycard migration flow

Expected behavior

Migration should end with a Profile key pair successfully migrated screen

Additional Information

• Status version: 2.32 release https://ci.infra.status.im/job/status-mobile/job/release/job/release%252F2.32.x/
• Operating System: Android

[flexsurfer]

	{"method": "convertToKeycardAccountV2", "duration": "3.273121461s", "request": [{"account":{"kdfIterations":3200,"key-uid":"0xca44355db13bf3ec8c29c361fffa1cb7f286cba9fc64e6a3cbaa62dab448d8ae","keycard-pairing":"ACKmyP11O6oYIS2jysxkpuW7mfMc1hBSXFpYKO4usHzg"},"keyUID":"0xca44355db13bf3ec8c29c361fffa1cb7f286cba9fc64e6a3cbaa62dab448d8ae","keycardUID":"774eb1925bd9ddd258e67d9bf87a686e","newPassword":"***","oldPassword":"***","settings":{"keycard-instance-uid":"774eb1925bd9ddd258e67d9bf87a686e","keycard-paired-on":1734092093627,"keycard-pairing":"ACKmyP11O6oYIS2jysxkpuW7mfMc1hBSXFpYKO4usHzg"}}], "response": {"error":"no key for given address or file"}}

"response": {"error":"no key for given address or file"

[igor-sirotin]

@flexsurfer the error seems to be coming from geth:
https://github.com/status-im/status-go/blob/31144ed5a38589fd129945b634f54e800b39645a/vendor/github.com/ethereum/go-ethereum/accounts/keystore/keystore.go#L46

Not sure at which stage of convertToKeycardAccountV2

[churik]

So just to clarify:
issue is reproducible for all accounts that are upgraded from v1 (1.20.x) and migrated to kk, they all see "Failed" screen.

I saw it only once.
I was testing on Android only as upgrade tests could only be tested there.

That comment was about java error

[flexsurfer]

hey @mariia-skrypnyk could you please remove error message from this task, and create separate, because it's not related and a minor issue

[mariia-skrypnyk]

@flexsurfer ok, done!

#21825

[churik]

Change a copy of what you need to do + button text

@ilmotta

[churik]

My 5 cents:

1. try to login with your keycard first (in bold) - under What you can do
2. Change Log out and Remove profile to "Log out" (it does not remove profile anyway)

[mariia-skrypnyk]

Hey @ilmotta !

This issue was fixed by UI solution to show such screen

For now, we have this 👆 screen at the end of the migration flow for upgraded users.
In fact, the migration is successful, regardless of the fact that something triggers the failure screen.
The user can tap on "Log out" and then successfully log in with their migrated key pair on the keycard.
Therefore, this issue should still be investigated and fixed if possible.

[ilmotta]

@mariia-skrypnyk such issues that we are tagging as upgrade v1, like this one, unless it's something critical, we should leave in the backlog. During this 2.33 release cycle, most likely we will reach a product-level decision about the kind of support we want to provide to users coming from v1, as well as a plan going forward to help users from v1 not lose some of their local data. The idea is to eventually stop supporting v1->v2 migration paths, thus no QA of v1->v2 flows, no bug fixes, investigation, etc. cc @churik @sunleos

[pavloburykh]

@mariia-skrypnyk such issues that we are tagging as upgrade v1, like this one, unless it's something critical, we should leave in the backlog. During this 2.33 release cycle, most likely we will reach a product-level decision about the kind of support we want to provide to users coming from v1, as well as a plan going forward to help users from v1 not lose some of their local data. The idea is to eventually stop supporting v1->v2 migration paths, thus no QA of v1->v2 flows, no bug fixes, investigation, etc. cc @churik @sunleos

Thanks for the answer @ilmotta! Based on this, I am removing this one from 2.33 milestone and leaving it in the Backlog.

[mariia-skrypnyk]

Thanks @ilmotta and @pavloburykh