Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Give non-destructive instructions when Keycard migration failed #21843

Merged

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Dec 18, 2024

Mitigates #21816

Summary

Give non-destructive instructions when Keycard migration failed.

status: ready

@ilmotta ilmotta self-assigned this Dec 18, 2024
@ilmotta ilmotta requested review from alwx and seanstrom December 18, 2024 14:21
@status-im-auto
Copy link
Member

status-im-auto commented Dec 18, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7c9c415 #1 2024-12-18 14:26:42 ~5 min tests 📄log
✔️ 7c9c415 #1 2024-12-18 14:28:23 ~7 min ios 📱ipa 📲
✔️ 7c9c415 #1 2024-12-18 14:30:58 ~9 min android-e2e 🤖apk 📲
✔️ 7c9c415 #1 2024-12-18 14:31:26 ~10 min android 🤖apk 📲

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff ✅

@status-im-auto
Copy link
Member

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 3
Expected to fail tests: 0
Passed tests: 5
IDs of failed tests: 727230,727229,703133 

Failed tests (3)

Click to expand
  • Rerun failed tests

  • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

    Device 1: Click until `Text` by `accessibility id`: `username` will be presented
    Device 1: Find `ProfileButton` by `accessibility id`: `open-profile`

    critical/chats/test_public_chat_browsing.py:162: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
        recover_user_name = self.home.get_username()
    ../views/home_view.py:631: in get_username
        profile_view.default_username_text.wait_for_element(3)
    ../views/base_element.py:129: in wait_for_element
        raise TimeoutException(
     Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element
    



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.14789 ETH

    critical/test_wallet.py:187: in test_wallet_send_asset_from_drawer
        self.errors.verify_no_errors()
    base_test_case.py:192: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Eth amount in the shdUaM8M6QcxQ4qn32nQs wallet is 0.3313 but should be 0.3315
    E    Eth amount in the shhWMbdtFbqsHau8w2CJs wallet is 0.1479 but should be 0.1479
    



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.14779 ETH

    critical/test_wallet.py:156: in test_wallet_send_eth
        self.errors.verify_no_errors()
    base_test_case.py:192: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Eth amount in the shdUaM8M6QcxQ4qn32nQs wallet is 0.3314 but should be 0.3316
    E    Eth amount in the shhWMbdtFbqsHau8w2CJs wallet is 0.1478 but should be 0.1478
    



    Passed tests (5)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @ilmotta thanks for the PR. Ready for merging into release branch and cherrypick into develop.

    @alwx alwx merged commit 398c30e into release/2.32.x Dec 18, 2024
    5 of 6 checks passed
    @alwx alwx deleted the ilmotta-21816/change-copy-on-failed-to-migrate-screen branch December 18, 2024 15:36
    @shivekkhurana shivekkhurana restored the ilmotta-21816/change-copy-on-failed-to-migrate-screen branch December 18, 2024 15:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: DONE
    Development

    Successfully merging this pull request may close these issues.

    7 participants