Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nix interpreter from 2.19.3 to 2.24.10 #21547

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Upgrade nix interpreter from 2.19.3 to 2.24.10 #21547

wants to merge 4 commits into from

Conversation

siddarthkay
Copy link
Contributor

Summary

This PR upgrades nix to 2.24.10.
We also fix the following warnings :

warning: ignoring the client-specified setting 'keep-derivations', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'keep-outputs', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'stalled-download-timeout', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'trusted-substituters', because it is a restricted setting and you are not a trusted user

Review notes (warning this maybe time consuming)

  • make nix-purge
  • restart your system
  • make shell will then install nix 2.24.10 for you.
  • Please test common workflows and make commands like :
    • make run-ios
    • make run-android
    • make run-clojure

Testing notes

should not be needed.

Platforms

  • Android
  • iOS

status: ready

@siddarthkay siddarthkay requested a review from jakubgs as a code owner November 1, 2024 17:23
@siddarthkay siddarthkay self-assigned this Nov 1, 2024
@siddarthkay siddarthkay requested a review from a team November 1, 2024 17:24
@status-im-auto
Copy link
Member

status-im-auto commented Nov 1, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (47)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 72ec1dc #1 2024-11-01 17:28:31 ~4 min tests 📄log
✔️ 72ec1dc #1 2024-11-01 17:31:47 ~7 min android-e2e 🤖apk 📲
✔️ 72ec1dc #1 2024-11-01 17:32:13 ~8 min android 🤖apk 📲
✔️ 72ec1dc #1 2024-11-01 17:33:11 ~9 min ios 📱ipa 📲
❌ bcfce20 #2 2024-11-01 18:14:38 ~43 sec tests 📄log
❌ bcfce20 #2 2024-11-01 18:14:39 ~44 sec android 📄log
❌ bcfce20 #2 2024-11-01 18:14:39 ~49 sec android-e2e 📄log
✔️ bcfce20 #2 2024-11-01 18:22:39 ~8 min ios 📱ipa 📲
❌ bcfce20 #3 2024-11-02 01:22:11 ~17 sec android 📄log
❌ bcfce20 #4 2024-11-02 01:23:40 ~14 sec android 📄log
❌ bcfce20 #5 2024-11-02 01:38:46 ~14 sec android 📄log
❌ bcfce20 #6 2024-11-02 01:39:47 ~14 sec android 📄log
❌ bcfce20 #7 2024-11-02 01:40:58 ~14 sec android 📄log
✔️ 91b73d7 #3 2024-11-02 03:22:51 ~8 min ios 📱ipa 📲
❌ 91b73d7 #3 2024-11-02 03:34:29 ~20 min tests 📄log
✔️ 91b73d7 #3 2024-11-02 03:51:49 ~37 min android-e2e 🤖apk 📲
✔️ 91b73d7 #10 2024-11-02 03:53:09 ~39 min android 🤖apk 📲
✔️ da9ca9c #4 2024-11-02 04:28:37 ~8 min ios 📱ipa 📲
✔️ da9ca9c #4 2024-11-02 04:28:45 ~8 min android-e2e 🤖apk 📲
✔️ da9ca9c #11 2024-11-02 04:29:13 ~9 min android 🤖apk 📲
✔️ da9ca9c #4 2024-11-02 04:33:37 ~13 min tests 📄log
✔️ 76d96fe #6 2024-11-12 08:14:58 ~6 min tests 📄log
✔️ 76d96fe #6 2024-11-12 08:17:10 ~9 min ios 📱ipa 📲
✔️ 76d96fe #6 2024-11-12 08:19:10 ~11 min android-e2e 🤖apk 📲
✔️ 76d96fe #13 2024-11-12 08:20:47 ~12 min android 🤖apk 📲
✔️ abce2a2 #7 2024-11-19 10:01:30 ~5 min tests 📄log
✔️ abce2a2 #7 2024-11-19 10:04:41 ~8 min ios 📱ipa 📲
✔️ abce2a2 #7 2024-11-19 10:05:42 ~9 min android-e2e 🤖apk 📲
✔️ abce2a2 #14 2024-11-19 10:06:16 ~10 min android 🤖apk 📲
✔️ 824993e #8 2024-11-20 07:57:13 ~5 min tests 📄log
✔️ 824993e #8 2024-11-20 08:00:59 ~8 min ios 📱ipa 📲
✔️ 824993e #8 2024-11-20 08:01:40 ~9 min android-e2e 🤖apk 📲
✔️ 824993e #15 2024-11-20 08:02:15 ~10 min android 🤖apk 📲
✔️ 1576e93 #9 2024-12-14 04:51:07 ~6 min ios 📱ipa 📲
✔️ 1576e93 #9 2024-12-14 04:55:18 ~10 min android-e2e 🤖apk 📲
✔️ 1576e93 #16 2024-12-14 04:55:52 ~11 min android 🤖apk 📲
✔️ 1576e93 #9 2024-12-14 05:00:04 ~15 min tests 📄log
❌ ed2e667 #10 2024-12-14 10:26:11 ~41 sec ios 📄log
✔️ ed2e667 #10 2024-12-14 10:30:34 ~5 min tests 📄log
✔️ ed2e667 #10 2024-12-14 10:35:07 ~9 min android-e2e 🤖apk 📲
✔️ ed2e667 #17 2024-12-14 10:35:33 ~10 min android 🤖apk 📲
✔️ ed2e667 #11 2024-12-14 10:46:49 ~17 min ios 📱ipa 📲
❌ a7895e7 #11 2025-01-02 01:55:23 ~6 min tests 📄log
✔️ a7895e7 #11 2025-01-02 01:59:45 ~11 min android-e2e 🤖apk 📲
✔️ a7895e7 #12 2025-01-02 02:00:01 ~11 min ios 📱ipa 📲
✔️ a7895e7 #18 2025-01-02 02:00:14 ~11 min android 🤖apk 📲
✔️ a7895e7 #12 2025-01-02 02:12:02 ~4 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3fb3c0c #13 2025-01-06 11:10:02 ~12 min ios 📱ipa 📲
✔️ 3fb3c0c #19 2025-01-06 11:11:53 ~14 min android 🤖apk 📲
✔️ 3fb3c0c #12 2025-01-06 11:12:25 ~14 min android-e2e 🤖apk 📲
✔️ 3dc0fab #14 2025-01-06 12:45:24 ~8 min ios 📱ipa 📲
✔️ 3dc0fab #13 2025-01-06 12:48:39 ~11 min android-e2e 🤖apk 📲
✔️ 3dc0fab #20 2025-01-06 12:49:15 ~12 min android 🤖apk 📲
✔️ 3dc0fab #15 2025-01-06 12:53:03 ~16 min tests 📄log

@siddarthkay siddarthkay marked this pull request as draft November 2, 2024 03:33
jakubgs
jakubgs reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this.

nix/shell.nix Outdated Show resolved Hide resolved
nix/nix.conf Outdated Show resolved Hide resolved
ci/Jenkinsfile.tests Outdated Show resolved Hide resolved
@siddarthkay siddarthkay force-pushed the upgrade-nix-2.24.x branch 2 times, most recently from a8f57d1 to 76d96fe Compare November 12, 2024 08:07
@siddarthkay siddarthkay force-pushed the upgrade-nix-2.24.x branch 2 times, most recently from abce2a2 to 824993e Compare November 20, 2024 07:51
@siddarthkay siddarthkay force-pushed the upgrade-nix-2.24.x branch 2 times, most recently from 1576e93 to ed2e667 Compare December 14, 2024 10:25
@siddarthkay siddarthkay marked this pull request as ready for review January 2, 2025 04:31
@siddarthkay siddarthkay requested a review from a team January 2, 2025 08:55
ilmotta
ilmotta approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DX worked just as well for me with NixOS 24.11

jakubgs
jakubgs approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I have tested this Nix release and it works with nimbus-eth2 as well.

@yakimant
Copy link
Member

yakimant commented Jan 6, 2025

Do we still build on x86 macOS? I would test it there too.

@status-im-auto
Copy link
Member

89% of end-end tests have passed

Total executed tests: 56
Failed tests: 1
Expected to fail tests: 5
Passed tests: 50

IDs of failed tests: 703133 

IDs of expected to fail tests: 727230,702844,741054,727229,703503

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

    Device 1: Tap on found: Button
    # STEP: Check that removed user is not shown in the list anymore

    critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Expected to fail tests (5)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2]
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:650: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No preview is loaded for url https://youtu.be/Je7yErjEVt4
E    No preview is loaded for url https://www.youtube.com/watch?v=XN-SVmuJH2g&list=PLbrz7IuP1hrgNtYe9g6YHwHO6F3OqNMao
E    No preview is loaded for url https://m.youtube.com/watch?v=Je7yErjEVt4

    [[Youtube links preview is not loaded on LambdaTest emulators, needs investigation]]

    Device sessions

    Class TestFallbackMultipleDevice:

    1. test_fallback_add_key_pair, id: 741054

    Device 2: Tap on found: Button
    Balance is Invalid API Key (#err2)|ARBTESTNET Gwei

    critical/test_fallback.py:232: in test_fallback_add_key_pair
    expected_balance = self.network_api.get_balance(key_pair_account_address)
../support/api/network_api.py:50: in get_balance
    return int(balance) / 1000000000000000000
 invalid literal for int() with base 10: 'Invalid API Key (#err2)|ARBTESTNET'

    [[Arbiscan API is down, looking for analogue]]

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Could not reach Button by pressing system back button
    Balance is Invalid API Key (#err2)|ARBTESTNET Gwei

    critical/test_wallet.py:166: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    sender_balance = self.network_api.get_balance(self.sender['wallet_address'])
../support/api/network_api.py:50: in get_balance
    return int(balance) / 1000000000000000000
 invalid literal for int() with base 10: 'Invalid API Key (#err2)|ARBTESTNET'

    [[Arbiscan API is down, looking for analogue]]

    2. test_wallet_send_eth, id: 727229

    Device 2: Tap on found: Button
    Balance is Invalid API Key (#err2)|ARBTESTNET Gwei

    critical/test_wallet.py:131: in test_wallet_send_eth
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    sender_balance = self.network_api.get_balance(self.sender['wallet_address'])
../support/api/network_api.py:50: in get_balance
    return int(balance) / 1000000000000000000
 invalid literal for int() with base 10: 'Invalid API Key (#err2)|ARBTESTNET'

    [[Arbiscan API is down, looking for analogue]]

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Find Button by accessibility id: communities-home-discover-card
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:260: in test_community_discovery
    self.home.community_card_item.wait_for_elements(seconds=120)
../views/base_element.py:137: in wait_for_elements
    raise TimeoutException(
 Device 1:  BaseElement by accessibility id:`community-card-item` is not found on the screen after wait_for_elements

    [[Might fail if the Discover curation dapp is too slow to load > 2 mins]]

    Device sessions

    Passed tests (50)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_unread_messages_badge, id: 702841
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links_profile, id: 702775
    Device sessions

    3. test_deep_links_communities, id: 739307
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestFallbackMultipleDevice:

    1. test_fallback_sync_with_error, id: 740220
    2. test_fallback_with_correct_seed_phrase, id: 740221
    3. test_fallback_validate_seed_phrase, id: 740222

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @siddarthkay
    Copy link
    Contributor Author

    Do we still build on x86 macOS?

    for mobile we don't

    status-mobile/ci/Jenkinsfile.ios

    Line 8 in 28a81f2

    agent { label 'macos && arm64 && nix-2.19 && xcode-15.1' }

    @pavloburykh
    Copy link
    Contributor

    @siddarthkay thanks for the PR. E2E results look good. If manual testing is not required PR is ready for merge.

    @pavloburykh pavloburykh self-assigned this Jan 9, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jakubgs jakubgs jakubgs approved these changes

    @yakimant yakimant yakimant approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @siddarthkay siddarthkay

    @pavloburykh pavloburykh

    Labels
    skip-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Status: MERGE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @siddarthkay @status-im-auto @yakimant @pavloburykh @ilmotta @jakubgs