chore: add support for remote devices with re-frisk server #21805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanstrom
changed the title
seanstrom
commented
Dec 11, 2024
| @@ -150,3 +150,6 @@ | |||
| (goog-define STATUS_BACKEND_SERVER_ROOT_DATA_DIR "") | |||
| ;; if you're using android simulator, I suggest set the env variable to "http://10.0.2.2:" | |||
| (goog-define STATUS_BACKEND_SERVER_IMAGE_SERVER_URI_PREFIX "https://localhost:") | |||
|
|
|||
| (def re-frisk-host (get-config :RE_FRISK_HOST "http://localhost")) | |||
There was a problem hiding this comment.
This is the default, but what I like to do is change this to my computer's local hostname. For example, when the mobile device and my laptop are on the same network, my phone can access my computer by its local hostname like dev.local.
This is nice because using the local hostname avoids needing to update the RE_FRISK_HOST variable whenever the IP address changes.
Jenkins BuildsClick to see older builds (4)
|
ilmotta
approved these changes
Dec 12, 2024
| @@ -269,9 +269,11 @@ run-metro: export TARGET := clojure | |||
| run-metro: ##@run Start Metro to build React Native changes | |||
| @scripts/run-metro.sh | |||
|
|
|||
| export RE_FRISK_PORT ?= 4567 | |||
There was a problem hiding this comment.
This port is also used in the target android-ports. Could you update references to 4567 to this var?
This change allows for the client app to connect to the configured host address and port.
seanstrom
force-pushed
the
seanstrom/dev-ux/refrisk-remote-support
branch
from
4a2519c to
1c6e664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Platforms
Areas that maybe impacted
Non-functional
status: ready