-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21336] feat: upgrade wallet connect #21833
Conversation
Jenkins BuildsClick to see older builds (4)
|
9954a7c
to
bc16ac9
Compare
100% of end-end tests have passed
Passed tests (8)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
|
@mohsen-ghafouri thank you for the PR. Please take a look at the issue below. Mind, that it is hard to verify if the issue is PR related or not. In PR I reproduce it most of the time, in develop we have faced the same issue but couple of times. ISSUE 1 Confirmation modal does not appear if event was triggered while Status app was offline (logged out)
Actual result: confirmation modal does not appear, cannot confirm triggered event. Status-debug-logs - 2024-12-20T151702.615.zip no_conf_modal.mp4 |
Besides that, I am facing different other random issues, which I try to investigate now. For example:
|
@mohsen-ghafouri regarding ISSUE 1 , we have logged a separate issue which is reproducible in develop, maybe those issues are related, I am not sure #21853. |
Hey @pavloburykh, thanks for testing this PR. I think the issue 1 is not related to my PR as we don't handle it logically. I will do more check to make sure. |
@mohsen-ghafouri if ISSUE 1 is not PR related, then PR is ready for merge. I can log ISSUE 1 separately. |
bc16ac9
to
2490a86
Compare
I will check Issue 1 along with #21853 |
fixes #21336
Summary
upgrade wallet connect to Reown library
Areas that maybe impacted
Test Note:
They only did some rebranding, but we also upgraded the minor version. Everything is supposed to work as it currently does. but please do a quick test in both android and iOS for sign and send transaction.
status: ready