Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21336] feat: upgrade wallet connect #21833

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Dec 17, 2024

fixes #21336

Summary

upgrade wallet connect to Reown library

Areas that maybe impacted

  • Wallet connect interaction

Test Note:

They only did some rebranding, but we also upgraded the minor version. Everything is supposed to work as it currently does. but please do a quick test in both android and iOS for sign and send transaction.

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Dec 17, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 17, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
e955672 #1 2024-12-17 08:23:09 ~4 min tests 📄log
✔️ e955672 #1 2024-12-17 08:28:22 ~9 min android-e2e 🤖apk 📲
✔️ e955672 #1 2024-12-17 08:28:29 ~9 min android 🤖apk 📲
✔️ e955672 #1 2024-12-17 08:28:57 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bc16ac9 #3 2024-12-17 12:30:08 ~4 min tests 📄log
✔️ bc16ac9 #3 2024-12-17 12:32:29 ~6 min android-e2e 🤖apk 📲
✔️ bc16ac9 #3 2024-12-17 12:34:14 ~8 min ios 📱ipa 📲
✔️ bc16ac9 #3 2024-12-17 12:34:44 ~8 min android 🤖apk 📲
✔️ 2490a86 #4 2024-12-24 09:33:07 ~4 min tests 📄log
✔️ 2490a86 #4 2024-12-24 09:34:50 ~6 min android-e2e 🤖apk 📲
✔️ 2490a86 #4 2024-12-24 09:35:00 ~6 min ios 📱ipa 📲
✔️ 2490a86 #4 2024-12-24 09:36:42 ~8 min android 🤖apk 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/upgrade-wallet-connect branch 2 times, most recently from 9954a7c to bc16ac9 Compare December 17, 2024 12:25
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review December 18, 2024 05:37
@mohsen-ghafouri mohsen-ghafouri requested a review from vkjr December 19, 2024 09:21
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 0
Passed tests: 8

Passed tests (8)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

@pavloburykh pavloburykh self-assigned this Dec 19, 2024
@pavloburykh
Copy link
Contributor

@mohsen-ghafouri thank you for the PR. Please take a look at the issue below. Mind, that it is hard to verify if the issue is PR related or not. In PR I reproduce it most of the time, in develop we have faced the same issue but couple of times.

ISSUE 1 Confirmation modal does not appear if event was triggered while Status app was offline (logged out)

  1. Connect to dapp (for example https://se-sdk-dapp.vercel.app/ )
  2. Logout Status app
  3. Trigger any request on dapp's side
  4. Login Status app
  5. Check if confirmation modal is shown

Actual result: confirmation modal does not appear, cannot confirm triggered event.

Status-debug-logs - 2024-12-20T151702.615.zip

no_conf_modal.mp4

@pavloburykh
Copy link
Contributor

Besides that, I am facing different other random issues, which I try to investigate now. For example:

  1. After confirming connection in Status app, it connection is not updated on dapp's side, i.e. QR code remains open, connected address is not displayed in dapp. At the same time dapp is listed among connected in Status app. This one is reproducible in develop as well.
  2. Sometimes event remains in Pending on dApp's side after signing in Status app. I have faced this problem once when swap on 1inch dapp.

@pavloburykh
Copy link
Contributor

@mohsen-ghafouri regarding ISSUE 1 , we have logged a separate issue which is reproducible in develop, maybe those issues are related, I am not sure #21853.

@mohsen-ghafouri
Copy link
Contributor Author

Hey @pavloburykh, thanks for testing this PR. I think the issue 1 is not related to my PR as we don't handle it logically. I will do more check to make sure.

@pavloburykh
Copy link
Contributor

Hey @pavloburykh, thanks for testing this PR. I think the issue 1 is not related to my PR as we don't handle it logically. I will do more check to make sure.

@mohsen-ghafouri if ISSUE 1 is not PR related, then PR is ready for merge. I can log ISSUE 1 separately.

@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/upgrade-wallet-connect branch from bc16ac9 to 2490a86 Compare December 24, 2024 09:27
@mohsen-ghafouri
Copy link
Contributor Author

I will check Issue 1 along with #21853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

Use the Reown dependency instead of WalletConnect
5 participants