Screens for editing transaction settings #21838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
vkjr
requested review from
shivekkhurana,
briansztamfater,
smohamedjavid,
mohsen-ghafouri and
alwx
vkjr
commented
Dec 17, 2024
| @@ -7,8 +7,8 @@ | |||
| [react-native.core :as rn] | |||
| [react-native.platform :as platform])) | |||
|
|
|||
| (defn- label-&-counter | |||
| [{:keys [label current-chars char-limit variant-colors theme]}] | |||
| (defn- label-line | |||
There was a problem hiding this comment.
In designs input field has labels at top-left and top-right sides. In our component we had only characters counter in the right side, so i added a right-side label.
vkjr
commented
Dec 17, 2024
| :number (count networks) | ||
| :size :size-16} | ||
| networks] | ||
| (when networks |
There was a problem hiding this comment.
If networks is empty we don't need this component because it eats some space and leads to incorrect alignment of text after it.
vkjr
commented
Dec 17, 2024
| (let [theme (quo.theme/use-theme) | ||
| window-width (:width (rn/get-window))] | ||
| [{:keys [token-symbol on-token-press value error? on-swap currency-symbol show-token-icon? | ||
| swappable?]}] |
There was a problem hiding this comment.
Two new features of token-input:
If not swappable? we won't display the button to swap between crypto and fiat values.
If not show-token-icon? we do not show icon. Because GWEI or UNITS that we enter in transaction settings screens do not have icons.
vkjr
commented
Dec 17, 2024
| @@ -78,16 +78,19 @@ | |||
|
|
|||
| (defn set-upper-limit | |||
| [state limit] | |||
| (when limit | |||
| (if limit | |||
There was a problem hiding this comment.
Without this change set-upper-limit breaks the usage of -> because no value returned when limit not applied
vkjr
commented
Dec 17, 2024
| @@ -768,3 +768,41 @@ | |||
| :always (update-in [:wallet :ui :send] dissoc :amount :route) | |||
| (not keep-tx-data?) (update-in [:wallet :ui :send] dissoc :tx-type)) | |||
| :fx [[:dispatch [:navigate-back]]]}))) | |||
|
|
|||
| (rf/reg-event-fx | |||
There was a problem hiding this comment.
I do not know yet in what form we will get the recommended and current values for transaction settings from status-go, so for now I've stored test values like that. Not a final form I believe.
vkjr
commented
Dec 17, 2024
| {:db (all-screens-params db (first comp-id) screen-params) | ||
| :fx [[:navigate-to-within-stack (conj comp-id (:theme db))]]}) | ||
| {:db (all-screens-params db (first comp-id) screen-params) | ||
| :dispatch-n [[:hide-bottom-sheet]] |
There was a problem hiding this comment.
Bottom sheets should be hidden when navigate to another screen. Copied from :navigate-to event above in the code.
vkjr
force-pushed
the
max-and-priority-fee-ui
branch
from
46862df to
dd4e08a
Compare
vkjr
force-pushed
the
max-and-priority-fee-ui
branch
from
dd4e08a to
31c80d2
Compare
alwx
approved these changes
Jan 7, 2025
vkjr
force-pushed
the
max-and-priority-fee-ui
branch
from
31c80d2 to
c5a2efd
Compare
mohsen-ghafouri
approved these changes
Jan 7, 2025
src/status_im/contexts/wallet/send/transaction_settings/view.cljs
Outdated
Show resolved
Hide resolved
smohamedjavid
approved these changes
Jan 7, 2025
vkjr
force-pushed
the
max-and-priority-fee-ui
branch
from
34177a6 to
a79acef
Compare
100% of end-end tests have passedPassed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21023 #21024
Summary
Implemented screens for editing Max base fee, Priority fee, Nonce and Max gas amount.
This is only UI implementation and it is hidden under feature flag.
status-go pr is not merged yet, so integration with status-go will be made separately
Screen.Recording.2024-12-17.at.15.50.35.mov
Review notes
Figma designs
In figma designs "max base fee" and "priority fee" use
token-inputcomponent withswapbutton that allows switching between fiat and crypto. In my implementation there is no switching because it is not practical. 1 gwei is just a fraction of cent and user will never operate in fiat to set fees. Also we never operate with values less than 1 cent in other parts of our app. (cc @xAlisher)Testing notes
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready