chore: resolve some deprecation warnings #21874

seanstrom · 2024-12-29T19:13:20Z

relates to #21868

Summary

This PR builds upon the work being done inside 🎄 🧹 New Year cleanup #21868
This PR attempts to resolve some the deprecation warning related to usage of colors/custom-color and rn/touchable-without-feedback.
- Nearly all usages of colors/custom-color have been replaced with colors/resolve-color, but some usages remain because we still rely on some of the special behaviour of colors/custom-color when retrieving the color for a network.
- All usages of rn/touchable-without-feedback have been replaced with rn/pressable.
Some deprecation warnings remain for usages of quo/text-combinations

Side Note

I've flagged some commit in my commit history with the flag: prefix. This is meant to describe that I'm not sure if the commit causes a regression. For example, in some cases we've relied on colors/custom-color for choosing a specific color based on the theme of the app, but sometimes we've overridden this pattern, so replacing these usages with colors/resolve-color is not 100% compliant. So perhaps we should review these changes carefully and decide whether we need to still use custom-colour for these use-cases.

Platforms

Android
iOS

Areas that maybe impacted

Potentially everything

status: ready

status-im-auto · 2024-12-29T19:16:48Z

Jenkins Builds

Click to see older builds (26)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`c2944f5`	#1	2024-12-29 19:16:48	~3 min	`tests`	📄`log`
✔️	`c2944f5`	#1	2024-12-29 19:20:42	~7 min	`android`	🤖`apk` 📲
✔️	`c2944f5`	#1	2024-12-29 19:20:51	~7 min	`ios`	📱`ipa` 📲
✔️	`c2944f5`	#1	2024-12-29 19:21:29	~7 min	`android-e2e`	🤖`apk` 📲

✔️	`bfdace4`	#2	2024-12-29 19:43:20	~4 min	`tests`	📄`log`
✔️	`bfdace4`	#2	2024-12-29 19:45:18	~6 min	`ios`	📱`ipa` 📲
✔️	`bfdace4`	#2	2024-12-29 19:47:02	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`bfdace4`	#2	2024-12-29 19:47:49	~9 min	`android`	🤖`apk` 📲

✔️	`3edfa00`	#3	2024-12-30 16:58:43	~4 min	`tests`	📄`log`
✔️	`3edfa00`	#3	2024-12-30 17:00:27	~6 min	`ios`	📱`ipa` 📲
✔️	`3edfa00`	#3	2024-12-30 17:02:47	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`3edfa00`	#3	2024-12-30 17:03:13	~9 min	`android`	🤖`apk` 📲

✔️	`06085c7`	#4	2025-01-02 16:46:47	~4 min	`tests`	📄`log`
✔️	`06085c7`	#4	2025-01-02 16:48:58	~6 min	`ios`	📱`ipa` 📲
✔️	`06085c7`	#4	2025-01-02 16:49:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`06085c7`	#4	2025-01-02 16:50:21	~8 min	`android`	🤖`apk` 📲
✔️	`06085c7`	#5	2025-01-06 12:08:21	~4 min	`tests`	📄`log`
✔️	`06085c7`	#5	2025-01-06 12:10:13	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`06085c7`	#5	2025-01-06 12:10:29	~6 min	`ios`	📱`ipa` 📲
✔️	`06085c7`	#5	2025-01-06 12:12:06	~8 min	`android`	🤖`apk` 📲

✔️	`5312f01`	#6	2025-01-06 18:49:03	~4 min	`tests`	📄`log`
✔️	`5312f01`	#6	2025-01-06 18:51:22	~6 min	`ios`	📱`ipa` 📲

✔️	`0c38f2e`	#8	2025-01-06 18:58:39	~4 min	`tests`	📄`log`
✔️	`0c38f2e`	#8	2025-01-06 19:01:11	~7 min	`android`	🤖`apk` 📲
✔️	`0c38f2e`	#8	2025-01-06 19:01:23	~7 min	`ios`	📱`ipa` 📲
✔️	`0c38f2e`	#8	2025-01-06 19:01:41	~7 min	`android-e2e`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`1322742`	#9	2025-01-06 19:27:28	~4 min	`tests`	📄`log`
✔️	`1322742`	#9	2025-01-06 19:29:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`1322742`	#9	2025-01-06 19:29:12	~6 min	`ios`	📱`ipa` 📲
✔️	`1322742`	#9	2025-01-06 19:31:12	~8 min	`android`	🤖`apk` 📲

✔️	`87fe66f`	#10	2025-01-08 19:53:13	~4 min	`tests`	📄`log`
✔️	`87fe66f`	#10	2025-01-08 19:55:28	~6 min	`ios`	📱`ipa` 📲
✔️	`87fe66f`	#10	2025-01-08 19:56:34	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`87fe66f`	#10	2025-01-08 19:57:10	~8 min	`android`	🤖`apk` 📲

ilmotta

I've flagged some commit in my commit history with the flag: prefix. This is meant to describe that I'm not sure if the commit causes a regression. For example, in some cases we've relied on colors/custom-color for choosing a specific color based on the theme of the app, but sometimes we've overridden this pattern, so replacing these usages with colors/resolve-color is not 100% compliant. So perhaps we should review these changes carefully and decide whether we need to still use custom-colour for these use-cases.

@seanstrom Are you suggesting that colors/custom-color might have legitimate use cases that resolve-color can't directly address? If so, should we consider removing the deprecation warning from custom-color ?

seanstrom · 2025-01-03T18:22:53Z

@ilmotta yes, I think custom-color may still have some valid use-cases but we may want to still move away from using that function.

For example, it seems that resolve-color is designed around the pattern of choosing the correct colour based on the given theme. Which seems to be useful and the correct pattern to follow for most of the old usages of custom-color. However, there are two use-cases that I noticed custom-color is still needed for:

Overriding the colour regardless of the theme

it seems there are a few places where want more control over the exact colour that is used, even if it goes against the pattern of relying on the theme. These usages could be outdated, or in need of a design review, but if they're necessary then we still need a function to override the colour choice.

Picking custom colours for things like icons or providers that have a unique colour that's not dependent on the theme. For example, we have a custom colour for Arbitrum, Optimism, and etc.

So perhaps we should create some new functions that handle these two use-cases separately, one function for overriding colours (override-color or another cautious name) and maybe another function for choosing brand colours (like special-color or brand-color).

Thoughts?

ilmotta · 2025-01-03T19:19:40Z

@seanstrom The idea of using explicit color functions for particular use cases is a nice idea.

It appears that colors/custom-color is now only used by a single quo preview namespace. Without production code usage, what do you think about getting rid of this function in this PR?

seanstrom · 2025-01-06T19:24:42Z

@seanstrom The idea of using explicit color functions for particular use cases is a nice idea.

Okay cool, I've added a new function named override-color for adding the option to choose a specific color-suffix (color variation). It's similar to how resolve-color works but it does not consider use the theme to choose the color-suffix.

It appears that colors/custom-color is now only used by a single quo preview namespace. Without production code usage, what do you think about getting rid of this function in this PR?

Ahh good catch! I've replaced that usage with resolve-color and removed the definition of custom-color 🙌

status-im-auto · 2025-01-06T19:38:53Z

50% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 2
Passed tests: 4

IDs of failed tests: 702745,702843

IDs of expected to fail tests: 727230,727229

Failed tests (2)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 1: Tap on found: Button
Device 1: Find `Button` by `accessibility id`: `next-button`

Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices
    self.community_1.invite_to_community(self.community_name, self.username_2)
../views/chat_view.py:392: in invite_to_community
    self.next_button.click()
../views/base_element.py:89: in click
    element = self.find_element()
../views/base_element.py:78: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 1: Tap on found: Button
Device 1: Find Button by xpath: //*[@content-desc='user-avatar']/following-sibling::android.view.ViewGroup[@content-desc='icon']

critical/chats/test_1_1_public_chats.py:281: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.profile_1.edit_profile_picture(image_index=0)
../views/profile_view.py:227: in edit_profile_picture
    self.change_profile_photo_button.click()
../views/base_element.py:89: in click
    element = self.find_element()
../views/base_element.py:78: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='user-avatar']/following-sibling::android.view.ViewGroup[@content-desc='icon']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Expected to fail tests (2)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 1: Could not reach Button by pressing system back button Balance is Invalid API Key (#err2)\|ARBTESTNET Gwei `critical/test_wallet.py:166: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:39: in _get_balances_before_tx sender_balance = self.network_api.get_balance(self.sender['wallet_address']) ../support/api/network_api.py:50: in get_balance return int(balance) / 1000000000000000000 invalid literal for int() with base 10: 'Invalid API Key (#err2)\|ARBTESTNET'` [[Arbiscan API is down, looking for analogue]]
2. test_wallet_send_eth, id: 727229
Device 2: Tap on found: Button Balance is Invalid API Key (#err2)\|ARBTESTNET Gwei `critical/test_wallet.py:131: in test_wallet_send_eth sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:39: in _get_balances_before_tx sender_balance = self.network_api.get_balance(self.sender['wallet_address']) ../support/api/network_api.py:50: in get_balance return int(balance) / 1000000000000000000 invalid literal for int() with base 10: 'Invalid API Key (#err2)\|ARBTESTNET'` [[Arbiscan API is down, looking for analogue]]

Passed tests (4)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

status-im-auto · 2025-01-09T10:32:39Z

50% of end-end tests have passed

Total executed tests: 56
Failed tests: 27
Expected to fail tests: 1
Passed tests: 28

IDs of failed tests: 702845,702840,702894,703086,702855,702947,702730,702958,702786,702745,702844,702841,702839,702733,702809,702838,702813,704615,702948,702859,703629,702957,702843,740220,703391,703194,740222

IDs of expected to fail tests: 703503

Failed tests (27)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device 1: Could not reach ChatsTab by pressing system back button Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:383: in test_1_1_chat_edit_message home.chats_tab.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device 1: Looking for a message by text: Message sender Device 1: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` critical/chats/test_1_1_public_chats.py:54: in test_1_1_chat_message_reaction self.chat_1.set_reaction(message_from_sender) ../views/chat_view.py:691: in set_reaction element.wait_for_element() ../views/base_element.py:128: in wait_for_element raise TimeoutException( Device `1`: `Button` by` accessibility id`: `reaction-thumbs-up` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Tap on found: Button Device 1: Find `Button` by `xpath`: `//[@content-desc='user-avatar']/following-sibling::android.view.ViewGroup[@content-desc='icon']` critical/chats/test_1_1_public_chats.py:281: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.profile_1.edit_profile_picture(image_index=0) ../views/profile_view.py:227: in edit_profile_picture self.change_profile_photo_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@content-desc='user-avatar']/following-sibling::android.view.ViewGroup[@content-desc='icon']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 2: Could not reach ChatsTab by pressing system back button Device 2: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:476: in test_1_1_chat_text_message_delete_push_disappear self.home_2.chats_tab.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device 1: ChatMessageInput element not found Device 1: Sending message 'Text push notification' critical/chats/test_1_1_public_chats.py:340: in test_1_1_chat_push_emoji self.chat_1.send_message(message) ../views/chat_view.py:628: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:128: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device 2: Could not reach ChatsTab by pressing system back button Device 2: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:411: in test_1_1_chat_send_image_save_and_share self.home_2.chats_tab.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Youtube links preview is not loaded on LambdaTest emulators, needs investigation]]
5. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
6. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 1: Tap on found: Button Device 1: Find `Button` by `accessibility id`: `next-button` Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
9. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
10. test_community_message_edit, id: 702843
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
11. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/chats/test_public_chat_browsing.py:339: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_mentions_push_notification, id: 702786
Device 1: Tap on found: Button Device 1: Find `Button` by `accessibility id`: `next-button` Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Can't navigate to a community channel before joining the community, https://github.com//issues/21776]]
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Can't navigate to a community channel before joining the community, https://github.com//issues/21776]]

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device 1: Tap on found: Button
Device 1: Find Button by accessibility id: next-button

Test setup failed: activity_center/test_activity_center.py:255: in prepare_devices
    self.community_1.invite_to_community(self.community_name, self.username_2)
../views/chat_view.py:392: in invite_to_community
    self.next_button.click()
../views/base_element.py:89: in click
    element = self.find_element()
../views/base_element.py:78: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:395: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_activity_center_mentions, id: 702957
Device 1: Tap on found: Button Device 1: Find `Button` by `accessibility id`: `next-button` Test setup failed: activity_center/test_activity_center.py:395: in prepare_devices self.community_1.invite_to_community(self.community_name, self.username_2) ../views/chat_view.py:392: in invite_to_community self.next_button.click() ../views/base_element.py:89: in click element = self.find_element() ../views/base_element.py:78: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `next-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestFallbackMultipleDevice:

1. test_fallback_sync_with_error, id: 740220
Device 2: Find `Text` by `accessibility id`: `progress-screen-title` Device 2: `Text` is `Oops, something’s wrong!` `critical/test_fallback.py:49: in test_fallback_sync_with_error assert self.sign_in_2.progress_screen_title.text == "Oops, something’s wrong" assert 'Oops, something’s wrong!' == 'Oops, something’s wrong' E - Oops, something’s wrong E + Oops, something’s wrong! E ? +`
2. test_fallback_validate_seed_phrase, id: 740222
Device 2: Find `Text` by `accessibility id`: `progress-screen-title` Device 2: `Text` is `Oops, something’s wrong!` `critical/test_fallback.py:261: in test_fallback_validate_seed_phrase assert self.sign_in_2.progress_screen_title.text == "Oops, something’s wrong" assert 'Oops, something’s wrong!' == 'Oops, something’s wrong' E - Oops, something’s wrong E + Oops, something’s wrong! E ? +`

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503

Device 1: Tap on found: Button
# STEP: Check Status community tags in the Discover communities screen

critical/chats/test_public_chat_browsing.py:297: in test_community_discovery
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Status' is not in the Discover Communities list.

[[Might fail if the Discover curation dapp is too slow to load > 2 mins]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (28)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links_profile, id: 702775
Device sessions Device 1: Steps, video, logs
3. test_deep_links_communities, id: 739307
Device sessions Device 1: Steps, video, logs

Class TestFallbackMultipleDevice:

1. test_fallback_add_key_pair, id: 741054

2. test_fallback_with_correct_seed_phrase, id: 740221

seanstrom self-assigned this Dec 29, 2024

seanstrom requested review from ilmotta and vkjr December 29, 2024 19:13

seanstrom mentioned this pull request Dec 29, 2024

🎄 🧹 New Year cleanup #21868

Merged

vkjr force-pushed the unused-cleanup branch from 82df7f7 to b2946d0 Compare December 30, 2024 15:10

vkjr approved these changes Dec 30, 2024

View reviewed changes

seanstrom force-pushed the seanstrom/deprecated-code branch from bfdace4 to 3edfa00 Compare December 30, 2024 16:53

vkjr force-pushed the unused-cleanup branch from 21586ed to f0cb6ce Compare January 2, 2025 14:02

seanstrom force-pushed the seanstrom/deprecated-code branch from 3edfa00 to 06085c7 Compare January 2, 2025 16:42

ilmotta approved these changes Jan 3, 2025

View reviewed changes

vkjr force-pushed the unused-cleanup branch from f0cb6ce to d8df128 Compare January 6, 2025 11:48

Base automatically changed from unused-cleanup to develop January 6, 2025 12:03

seanstrom force-pushed the seanstrom/deprecated-code branch 3 times, most recently from 5c97827 to 0c38f2e Compare January 6, 2025 18:53

seanstrom added the request-manual-qa label Jan 6, 2025

seanstrom force-pushed the seanstrom/deprecated-code branch from 0c38f2e to 1322742 Compare January 6, 2025 19:22

seanstrom added 5 commits January 8, 2025 11:48

chore: use rn/pressable instead of rn/touchable-without-feedback

bfe3b32

chore: use colors/resolve-color instead of colors/custom-color`

a4e4509

chore: add override-color utility

81b9aee

chore: use colors/override-color instead of colors/custom-color

4b61124

chore: remove definition of colors/custom-color

87fe66f

seanstrom force-pushed the seanstrom/deprecated-code branch from 1322742 to 87fe66f Compare January 8, 2025 19:48

mariia-skrypnyk self-assigned this Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: resolve some deprecation warnings #21874

chore: resolve some deprecation warnings #21874

seanstrom commented Dec 29, 2024 •

edited

Loading

status-im-auto commented Dec 29, 2024 •

edited

Loading

ilmotta left a comment

seanstrom commented Jan 3, 2025

ilmotta commented Jan 3, 2025

seanstrom commented Jan 6, 2025

status-im-auto commented Jan 6, 2025

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

status-im-auto commented Jan 9, 2025

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestFallbackMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestFallbackMultipleDevice:

chore: resolve some deprecation warnings #21874

Are you sure you want to change the base?

chore: resolve some deprecation warnings #21874

Conversation

seanstrom commented Dec 29, 2024 • edited Loading

Summary

Side Note

Platforms

Areas that maybe impacted

status-im-auto commented Dec 29, 2024 • edited Loading

Jenkins Builds

ilmotta left a comment

Choose a reason for hiding this comment

seanstrom commented Jan 3, 2025

ilmotta commented Jan 3, 2025

seanstrom commented Jan 6, 2025

status-im-auto commented Jan 6, 2025

50% of end-end tests have passed

Failed tests (2)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Expected to fail tests (2)

Class TestWalletMultipleDevice:

Passed tests (4)

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

status-im-auto commented Jan 9, 2025

50% of end-end tests have passed

Failed tests (27)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestFallbackMultipleDevice:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (28)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestFallbackMultipleDevice:

seanstrom commented Dec 29, 2024 •

edited

Loading

status-im-auto commented Dec 29, 2024 •

edited

Loading