-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21836] Relative derivation paths are not supported by keycard #21888
base: develop
Are you sure you want to change the base?
[#21836] Relative derivation paths are not supported by keycard #21888
Conversation
Hi @flexsurfer , I just checked relate code in status-go, just like as you said before, m/1 is not equal to m/44/60/0/0/1 . And it seems there's no relations between // Derive returns a derived child key at a given path
func (k *ExtendedKey) Derive(path []uint32) (*ExtendedKey, error) {
var err error
extKey := k
for _, i := range path {
extKey, err = extKey.Child(i)
if err != nil {
return nil, ErrDerivingChild
}
}
return extKey, nil
} |
:derivation-path (create-account.utils/normalize-path | ||
@derivation-path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other place within this same file/screen might need normalization:
status-mobile/src/status_im/contexts/wallet/add_account/create_account/view.cljs
Line 294 in ce1d2c4
:derivation-path @derivation-path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this one is tricky i wouldn't change it now, because path might be edited there
75% of end-end tests have passed
Failed tests (2)Click to expandClass TestWalletOneDevice:
Passed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
|
fixes #21836
it fixed main issue, but also i fixed path in the about tab for account, but most likely there are more places with the wrong path, but i don't want to mess with it in this PR