[#21652] The main part of a backup flow is missing at Keycard migrati… #21893

flexsurfer · 2025-01-07T13:22:55Z

QA: please also check new keypair creation in the wallet

status-im-auto · 2025-01-07T13:25:50Z

Jenkins Builds

Click to see older builds (5)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`cf68b04`	#1	2025-01-07 13:25:49	~2 min	`tests`	📄`log`

✔️	`4b20227`	#2	2025-01-07 13:34:24	~4 min	`tests`	📄`log`
✔️	`4b20227`	#2	2025-01-07 13:36:58	~7 min	`android`	🤖`apk` 📲
✔️	`4b20227`	#2	2025-01-07 13:37:07	~7 min	`ios`	📱`ipa` 📲
✔️	`4b20227`	#2	2025-01-07 13:37:36	~7 min	`android-e2e`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`628b671`	#3	2025-01-09 10:04:29	~4 min	`tests`	📄`log`
✔️	`628b671`	#3	2025-01-09 10:06:34	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`628b671`	#3	2025-01-09 10:07:33	~7 min	`ios`	📱`ipa` 📲
✔️	`628b671`	#3	2025-01-09 10:07:55	~8 min	`android`	🤖`apk` 📲

✔️	`3870c3b`	#4	2025-01-09 11:02:05	~4 min	`tests`	📄`log`
✔️	`3870c3b`	#4	2025-01-09 11:04:01	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`3870c3b`	#4	2025-01-09 11:05:01	~7 min	`ios`	📱`ipa` 📲
✔️	`3870c3b`	#4	2025-01-09 11:05:45	~8 min	`android`	🤖`apk` 📲

seanstrom

Looks good ✅

Left one small comment about how the UI may change wallet-UX, but I'm not sure.

seanstrom · 2025-01-07T14:54:46Z

src/status_im/contexts/wallet/add_account/create_account/new_keypair/confirm_backup/view.cljs

+            {:icon-name           :i/close
             :on-press            #(rf/dispatch [:navigate-back])


Does this change affect the wallet UX? For example, does the wallet-flow for backing up the seed-phrase still need a back-arrow?

cc @smohamedjavid

it was wrong before, it's modal but it had back arrow, so it's fixed now

status-im-auto · 2025-01-07T16:18:39Z

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 0
Passed tests: 8

Passed tests (8)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

mariia-skrypnyk · 2025-01-09T08:21:37Z

Hi @flexsurfer !

As we have changes in design it would be great if we ad these parts to our keycard migration backup flow:

1) restriction to make a screenshot

2) Complete backup drawer

3) Verify your backup drawer

https://www.figma.com/design/YGm3igIOAcwMqUVJWCJ6f1/Keycard?node-id=3395-33010&m=dev

This flow relates specifically to the keycard functionality. At the moment, the create account flow is outdated and awaiting an update.

…on flow and Create User flow

flexsurfer · 2025-01-09T10:00:02Z

thanks @mariia-skrypnyk 2 - fixed, please make separate tasks for 1 and 3

mariia-skrypnyk · 2025-01-09T10:41:30Z

Hey @flexsurfer !

Please, fix 2 small issues:

there is a typo in design, we need to use "recovery phrase"
text should not exceed the boarder

flexsurfer · 2025-01-09T10:58:20Z

thanks @mariia-skrypnyk 1 fixed , for 2 pls create follow up because it seems like it's a different component we need to create or fix current component

status-im-auto · 2025-01-09T13:22:38Z

38% of end-end tests have passed

Total executed tests: 8
Failed tests: 5
Expected to fail tests: 0
Passed tests: 3

IDs of failed tests: 727231,727230,703133,740490,727229

Failed tests (5)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

Device 1: Click until `Text` by `accessibility id`: `username` will be presented
Device 1: Find `ProfileButton` by `accessibility id`: `open-profile`

critical/chats/test_public_chat_browsing.py:162: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    recover_user_name = self.home.get_username()
../views/home_view.py:528: in get_username
    profile_view.default_username_text.wait_for_element(3)
../views/base_element.py:128: in wait_for_element
    raise TimeoutException(
 Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element

Device sessions

Device 1:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:32: in prepare_devices self.sender_username, self.receiver_username = self.home_1.get_username(), self.home_2.get_username() ../views/home_view.py:528: in get_username profile_view.default_username_text.wait_for_element(3) ../views/base_element.py:128: in wait_for_element raise TimeoutException( Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element
2. test_wallet_send_eth, id: 727229
Device 1: Click until `Text` by `accessibility id`: `username` will be presented Device 1: Find `ProfileButton` by `accessibility id`: `open-profile` Test setup failed: critical/test_wallet.py:32: in prepare_devices self.sender_username, self.receiver_username = self.home_1.get_username(), self.home_2.get_username() ../views/home_view.py:528: in get_username profile_view.default_username_text.wait_for_element(3) ../views/base_element.py:128: in wait_for_element raise TimeoutException( Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Test setup failed: critical/test_wallet.py:223: in prepare_devices self.sender_username = self.home_view.get_username() ../views/home_view.py:528: in get_username profile_view.default_username_text.wait_for_element(3) ../views/base_element.py:128: in wait_for_element raise TimeoutException( Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element
2. test_wallet_balance_mainnet, id: 740490
Device 1: Click until `Text` by `accessibility id`: `username` will be presented Device 1: Find `ProfileButton` by `accessibility id`: `open-profile` Test setup failed: critical/test_wallet.py:223: in prepare_devices self.sender_username = self.home_view.get_username() ../views/home_view.py:528: in get_username profile_view.default_username_text.wait_for_element(3) ../views/base_element.py:128: in wait_for_element raise TimeoutException( Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element

Passed tests (3)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2025-01-09T14:09:20Z

Thanks @flexsurfer !
E2E fails are not related and PR can be merged.

flexsurfer added request-manual-qa keycard labels Jan 7, 2025

flexsurfer requested review from seanstrom, Parveshdhull and smohamedjavid January 7, 2025 13:22

flexsurfer self-assigned this Jan 7, 2025

seanstrom approved these changes Jan 7, 2025

View reviewed changes

smohamedjavid approved these changes Jan 7, 2025

View reviewed changes

Parveshdhull approved these changes Jan 8, 2025

View reviewed changes

mariia-skrypnyk self-assigned this Jan 8, 2025

[#21652] The main part of a backup flow is missing at Keycard migrati…

628b671

…on flow and Create User flow

flexsurfer force-pushed the feature/The-main-part-of-a-backup-flow-is-missing-at-Keycard-migration-flow-and-Create-User-flow-#21652 branch from 4b20227 to 628b671 Compare January 9, 2025 09:59

mariia-skrypnyk added the Tested - Issues label Jan 9, 2025

typo

3870c3b

flexsurfer removed the Tested - Issues label Jan 9, 2025

mariia-skrypnyk added Tested - OK followup-required labels Jan 9, 2025

mariia-skrypnyk mentioned this pull request Jan 9, 2025

No way to reopen "Confirm backup" drawer after cancelling during backup key pair during keycard migration flow #21903

Open

flexsurfer merged commit 0472523 into develop Jan 9, 2025
5 checks passed

flexsurfer deleted the feature/The-main-part-of-a-backup-flow-is-missing-at-Keycard-migration-flow-and-Create-User-flow-#21652 branch January 9, 2025 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#21652] The main part of a backup flow is missing at Keycard migrati… #21893

[#21652] The main part of a backup flow is missing at Keycard migrati… #21893

flexsurfer commented Jan 7, 2025

status-im-auto commented Jan 7, 2025 •

edited

Loading

seanstrom left a comment

seanstrom Jan 7, 2025

flexsurfer Jan 7, 2025 •

edited

Loading

status-im-auto commented Jan 7, 2025

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

mariia-skrypnyk commented Jan 9, 2025

flexsurfer commented Jan 9, 2025

mariia-skrypnyk commented Jan 9, 2025

flexsurfer commented Jan 9, 2025

status-im-auto commented Jan 9, 2025

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mariia-skrypnyk commented Jan 9, 2025

		{:icon-name :i/close
		:on-press #(rf/dispatch [:navigate-back])

[#21652] The main part of a backup flow is missing at Keycard migrati… #21893

[#21652] The main part of a backup flow is missing at Keycard migrati… #21893

Conversation

flexsurfer commented Jan 7, 2025

status-im-auto commented Jan 7, 2025 • edited Loading

Jenkins Builds

seanstrom left a comment

Choose a reason for hiding this comment

seanstrom Jan 7, 2025

Choose a reason for hiding this comment

flexsurfer Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

status-im-auto commented Jan 7, 2025

100% of end-end tests have passed

Passed tests (8)

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

mariia-skrypnyk commented Jan 9, 2025

flexsurfer commented Jan 9, 2025

mariia-skrypnyk commented Jan 9, 2025

flexsurfer commented Jan 9, 2025

status-im-auto commented Jan 9, 2025

38% of end-end tests have passed

Failed tests (5)

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Passed tests (3)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mariia-skrypnyk commented Jan 9, 2025

status-im-auto commented Jan 7, 2025 •

edited

Loading

flexsurfer Jan 7, 2025 •

edited

Loading