Identify min vers of assets that reside outside of the $relative_asse_path #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can reproduce the issue being fixed with any resource that resides outside of the configured relative path.
For example the resource in common
vendor/jquery-tribe-timepicker/jquery.timepicker.js.The specific version is being shipped without the unminified version and the minified would fail to be detected. the reason is that the regex replace is dependent on the asset residing within the configured relative asset path. In the case of common thats
src/resourcesEvaluating if the asset relative path is different from the min asset path, i think its enough in this case. In case they were different that must at the very least means that the
tribe_assetfunction has evolved to support different locations of min vs non-min. At that point, it should probably support different relative paths per resources or we would have refactored everytribe_assetcall to account for different group of resources.I can add tests, just wanted to see if we are ok initially with the patch before moving forward.