replace the DIRECTORY_SEPARATE with slash for other OS #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure that if the OS is not *nix, then the DIRECTORY_SEPARATOR in the $path will be parsed correctly, along with the $plugin_dir.
Problem:
The
$plugin_dir
gets parsed, while the$path
is still contains the different DS, which will make the check$plugins_content_dir_position = strpos( $path, $plugin_dir );
always false, such as C:\sites... vs C:/sites/...