Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding groups of paths #24

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Adding groups of paths #24

merged 13 commits into from
Oct 22, 2024

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Oct 22, 2024

The idea behind this PR is that the existing logic locks us in only using ONE specific root path and ONE relative path. This is not the case for most plugins/themes and much more for the TEC products.

Registering a group of paths can enable us managing multiple locations of assets with the single instance stellar assets.

Use cases:

Declare a group for Event Tickets core
Declare a group for Event Tickets seating
Declare a group for Event Tickets Plus
Declare a group for The events calendar
Declare a group for Events Pro
etc...

@dpanta94 dpanta94 requested review from borkweb and lucatume October 22, 2024 14:45
@dpanta94 dpanta94 self-assigned this Oct 22, 2024
@dpanta94 dpanta94 added the enhancement New feature or request label Oct 22, 2024
@dpanta94 dpanta94 requested a review from bordoni October 22, 2024 14:52
tests/wpunit/ConfigTest.php Outdated Show resolved Hide resolved
@dpanta94 dpanta94 requested a review from lucatume October 22, 2024 15:36
tests/wpunit/ConfigTest.php Outdated Show resolved Hide resolved
tests/wpunit/ConfigTest.php Outdated Show resolved Hide resolved
tests/wpunit/AssetsTest.php Show resolved Hide resolved
tests/wpunit/AssetsTest.php Show resolved Hide resolved
dpanta94 and others added 4 commits October 22, 2024 18:50
Co-authored-by: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
Co-authored-by: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller typo change, then good for me.

tests/wpunit/AssetsTest.php Outdated Show resolved Hide resolved
Co-authored-by: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
@dpanta94 dpanta94 merged commit c35ada8 into main Oct 22, 2024
3 checks passed
@dpanta94 dpanta94 deleted the feat/add-groups-of-paths branch October 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants