Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehint parameters in accordance with ContainerInterface #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnwjn
Copy link

@dnwjn dnwjn commented Aug 8, 2024

Hi team!

We ran into an issue with the Restrict Content plugin and the WP CLI. We would get the following exception:

PHP Fatal error:  Declaration of Illuminate\Container\Container::get(string $id) must be compatible with Psr\Container\ContainerInterface::get($id) in /<redacted>/vendor/illuminate/container/Container.php on line 714

We pinpointed the issue to be in your plugin as disabling it, or typehinting the parameters as done in this PR, would resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant