Adopt the stellarwp/db library (version 1.1.0) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucatume
reviewed
Aug 29, 2022
| * @see https://github.com/BrianHenryIE/strauss | ||
| */ | ||
|
|
||
| $aliases = [ |
There was a problem hiding this comment.
The class_alias function will pre-load the aliased classes when you call it. Not an issue in this specific application, but something to note/share when eager-loading of the classes is not a desirable side effect. The solution to keep lazy-loading aliased classes is to do so in an autoload function.
lucatume
approved these changes
Aug 29, 2022
borkweb
added a commit
that referenced
this pull request
Sep 15, 2022
This PR builds on top of the original PR (#5) to add the DB library into the mix. Within you will find: 1. Removal of the `di52` library. Instead, `StellarWP\Schema\Config::set_container( $container )` must be used. 1. I've refactored some of the `di52`-specific features (service providers, `getVar`/`setVar`, etc ) to be more friendly to other containers that implement the core `singleton()`, `make()`, and `bind()` methods. 1. I've removed the `stellarwp/db` as an included library. Instead, the project that uses `stellarwp/schema` should inject the `DB::class` via `StellarWP\Schema\Config::set_db( DB::class )` Note: I imagine further iterations on this code will be needed before we merge it fully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adopts the stellarwp/db library and uses it for database operations.
$wpdbcalls with theDBclass.Addresses: #7