[FRAME-91] Asset File Structure #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMKindred
suggested changes
Nov 17, 2022
There was a problem hiding this comment.
We need to start adding docblocks to classes, methods, and filters for new files to help cut down on additional work in a refactoring pass.
I am not sure that there are many options for only loading the js and CSS when needed, but something I'd like us to think about as we continue forward.
tarecord
reviewed
Nov 18, 2022
tarecord
reviewed
Nov 22, 2022
|
@tarecord This PR is ready for re-review. It tackles tickets https://moderntribe.atlassian.net/browse/FRAME-91 and https://moderntribe.atlassian.net/browse/FRAME-96 |
tarecord
requested changes
Nov 28, 2022
dotjon
changed the title
dotjon
commented
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enqueue the admin assets, and change the directory structure to house resources.
src/
++Telemetry/ ← class files here
++++Contracts/
++++++CronJob.php
++++Telemetry.php
++resources/ ← assets here
++++css/
++++images/
++++++Logo.png
++++js/
++views/