-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Multi AZ Failover #5
Open
mattbucci
wants to merge
3
commits into
stelligent:master
Choose a base branch
from
mattbucci:feature/cross-az
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbucci
changed the title
add support for AZMode configuration and default cross az mode to on
WIP:add support for AZMode configuration and default cross az mode to on
Mar 29, 2019
Update: this fails with "NumCacheNodes should be 1 if engine is redis" In order to leverage MultiAZ we must use https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticache-replicationgroup.html |
mattbucci
force-pushed
the
feature/cross-az
branch
from
March 29, 2019 05:09
eef4554
to
fe1cb11
Compare
mattbucci
changed the title
WIP:add support for AZMode configuration and default cross az mode to on
dd support for AZMode configuration and default cross az mode to on
Mar 29, 2019
mattbucci
changed the title
dd support for AZMode configuration and default cross az mode to on
Add support for AZMode configuration and default cross az mode to on
Mar 29, 2019
mattbucci
changed the title
Add support for AZMode configuration and default cross az mode to on
Add support for Multi AZ Failover
Mar 29, 2019
mattbucci
force-pushed
the
feature/cross-az
branch
from
April 1, 2019 19:45
fe1cb11
to
91e107a
Compare
gessgallardo
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…or endpoint address and port
Move from inline policy to managed policy, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4