GCC Action Flags (#1563)

* Adding Wall Werror to GCC actions * Update jmespath.cpp * Fix missing break and fix GCC unused warning * Attempt GCC warning fix * GCC warning hidden? * GCC fix? * Wundefined-symbols * Weverything * Update to_tuple.hpp * Fix GCC warning * Won't use Werror on GCC12 * Update CMakeLists.txt
stephenberry · Jan 13, 2025 · 70b4a10 · 70b4a10
1 parent 5980f9a
commit 70b4a10
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/include/glaze/json/schema.hpp b/include/glaze/json/schema.hpp
@@ -263,7 +263,7 @@ struct glz::meta<glz::detail::schematic>
                                     "ExtUnits", //
                                     "ExtAdvanced"};
 
-   static constexpr glz::tuple value{&T::type, //
+   [[maybe_unused]] static constexpr glz::tuple value{&T::type, //
                                      &T::properties, //
                                      &T::items, //
                                      &T::additionalProperties, //

diff --git a/include/glaze/json/skip.hpp b/include/glaze/json/skip.hpp
@@ -213,6 +213,7 @@ namespace glz::detail
          skip_comment(ctx, it, end);
          if (bool(ctx.error)) [[unlikely]]
             return;
+         break;
       }
       case 'n': {
          ++it;

diff --git a/include/glaze/json/write.hpp b/include/glaze/json/write.hpp
@@ -1580,7 +1580,7 @@ namespace glz
             using V = std::decay_t<decltype(value.value)>;
             static constexpr auto N = glz::tuple_size_v<V>;
 
-            static constexpr auto Opts = opening_and_closing_handled<Options>();
+            [[maybe_unused]] static constexpr auto Opts = opening_and_closing_handled<Options>();
 
             // When merging it is possible that objects are completed empty
             // and therefore behave like skipped members even when skip_null_members is off

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -23,7 +23,13 @@ target_compile_features(glz_test_common INTERFACE cxx_std_23)
 target_link_libraries(glz_test_common INTERFACE ut::ut glaze::glaze)
 if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
     target_compile_options(glz_test_common INTERFACE -fno-exceptions -fno-rtti)
-    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+        if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 13)
+            target_compile_options(glz_test_common INTERFACE -Wall -Wextra -pedantic)
+        else()
+            target_compile_options(glz_test_common INTERFACE -Wall -Wextra -pedantic $<$<CONFIG:Debug>:-Werror>)
+        endif()
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         target_compile_options(glz_test_common INTERFACE -Wall -Wextra -pedantic $<$<CONFIG:Debug>:-Werror>)
     else()
         target_compile_options(glz_test_common INTERFACE -Wall -Wextra -pedantic)

diff --git a/tests/jmespath/jmespath.cpp b/tests/jmespath/jmespath.cpp
@@ -192,11 +192,6 @@ struct gcc_maybe_uninitialized_t
    int cqqq{};
 };
 
-struct test_wrapper_t
-{
-   gcc_maybe_uninitialized_t test{};
-};
-
 suite gcc_maybe_uninitialized_tests = [] {
    "gcc_maybe_uninitialized"_test = [] {
       using namespace std::string_view_literals;
-Original file line number
+Diff line change
@@ Expand Up / @@ -213,6 +213,7 @@ namespace glz::detail @@
              skip_comment(ctx, it, end);
              if (bool(ctx.error)) [[unlikely]]
                 return;
+             break;
           }
           case 'n': {
              ++it;
@@ Expand Down @@