Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-claims): allow carpark fallback on content claims #14

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

hannahhoward
Copy link
Member

Goals

Temp fix our gateway problems while we search for deeper solutions

Implementation

Since fetching of indexes is broken, this works around it by just checking CAR park directly.

@hannahhoward hannahhoward force-pushed the feat/read-from-carpark branch from 7f7cd78 to f657b2a Compare October 31, 2024 16:40
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit 5ffc150 into main Oct 31, 2024
1 check passed
hannahhoward added a commit to storacha/indexing-service that referenced this pull request Jan 10, 2025
# Goals

Return location claims that were never published properly on the blob
protocol from ~May - November 2024
fix #63

# Implementation

Essentially this ports storacha/blob-fetcher#14

- When no legacy claims are found in the legacy claims bucket, check if
the cid in question has an uploaded blob in carpark (via head request)
- if present, generate a location claim on demand, in much the same way
we do for data pre-blob protocol data (reading from the blob-index
table)
- however, here we fold into the normal indexing query process, and the
way we accomplish this is via identity CIDs. Which is... a bit funky,
but seems the simplest mechanism for making everything work together :)

# For Discussion

TODO:
- test for bucketFallbackMapper
- maybe integration test the whole thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants