Refactor Clients initialization to accept timeout duration

Updated the Clients struct to include a maxBlockFetchDuration parameter, enhancing flexibility in specifying timeout durations for block fetching. This change was reflected in the initialization function and associated test cases.

blockpoller/poller_test.go

@@ -5,12 +5,12 @@ import (
 	"fmt"
 	"strconv"
 	"testing"
-
-	"github.com/streamingfast/firehose-core/rpc"
+	"time"
 
 	"github.com/streamingfast/bstream"
 	"github.com/streamingfast/bstream/forkable"
 	pbbstream "github.com/streamingfast/bstream/pb/sf/bstream/v1"
+	"github.com/streamingfast/firehose-core/rpc"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -167,7 +167,7 @@ func TestForkHandler_run(t *testing.T) {
 			blockFetcher := newTestBlockFetcher[any](t, tt.blocks)
 			blockFinalizer := newTestBlockFinalizer(t, tt.expectFireBlock)
 
-			clients := rpc.NewClients[any]()
+			clients := rpc.NewClients[any](1 * time.Second)
 			clients.Add(new(any))
 
 			poller := New(blockFetcher, blockFinalizer, clients)

rpc/clients.go

@@ -11,13 +11,15 @@ import (
 var ErrorNoMoreClient = errors.New("no more clients")
 
 type Clients[C any] struct {
-	clients []C
-	next    int
+	clients               []C
+	next                  int
+	maxBlockFetchDuration time.Duration
 }
 
-func NewClients[C any]() *Clients[C] {
+func NewClients[C any](maxBlockFetchDuration time.Duration) *Clients[C] {
 	return &Clients[C]{
-		next: 0,
+		next:                  0,
+		maxBlockFetchDuration: maxBlockFetchDuration,
 	}
 }
 
@@ -44,7 +46,7 @@ func WithClients[C any, V any](clients *Clients[C], f func(context.Context, C) (
 			return v, errs
 		}
 		ctx := context.Background()
-		ctx, cancel := context.WithTimeout(ctx, 1*time.Second) //todo: add to parameters
+		ctx, cancel := context.WithTimeout(ctx, clients.maxBlockFetchDuration)
 		v, err := f(ctx, client)
 		cancel()
 		if err != nil {