-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 #35
Conversation
This is made to not assume that the default db is the one always used.
PostGIS backend uses connection the DB provided by get_queryset.
# Conflicts: # docs/changelog.rst
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
371130 | Assigned | Django Secret Key | 634cae3 | test_vectortiles/settings/init.py | View secret |
371130 | Assigned | Django Secret Key | 7a07566 | test_vectortiles/settings/init.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage ? 89.83%
=========================================
Files ? 13
Lines ? 305
Branches ? 0
=========================================
Hits ? 274
Misses ? 31
Partials ? 0 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
... | ||
|
||
# in your settings file | ||
ALLOWED_HOSTS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALLOWED_HOSTS = [ | |
ALLOWED_HOSTS = [ |
docs/changelog.rst
Outdated
@@ -4,6 +4,11 @@ CHANGELOG | |||
1.0.0.a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.0.a1 | |
1.0.0-beta |
** Breaking changes ** | ||
|
||
* Refactor PostGIS and Python (old named MapBox) backends usage. Use setting to set (default postgis) | ||
* No DetailView anymore. As Tile can have many layers, declare VectorLayer on MTVView (one or many). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: MVTView
return layers_min_zoom if layers_min_zoom is not None else 0 | ||
|
||
def get_max_zoom(self): | ||
"""Get tilejson manzoom from layers or self.man_zoom""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo :D 🕺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still struggling to understand how I would implement the #44 usecase, but I'm just curious, no concrete application at the moment here. An example in the README can be useful. never mind, found it:
Line 68 in e90adb6
layer_classes = [FeatureVectorLayer] |
In general, looks very good, great job to refactor the whole codebase!
@@ -17,101 +17,117 @@ | |||
pip install django-vectortiles | |||
``` | |||
|
|||
* Without any other option, use only vectortiles.postgis | |||
* By default, postgis backend is enabled. | |||
* Ensure you have psycopg2 set and installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note that psycopg
is also supported.
✨ First official release