Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 #35

Merged
merged 39 commits into from
Feb 8, 2024
Merged

v1 #35

merged 39 commits into from
Feb 8, 2024

Conversation

submarcos
Copy link
Owner

@submarcos submarcos commented Feb 16, 2023

✨ First official release

  • Manage mutiple layers in tile
  • Manage TileJSON
  • Refactor Postgis / Python(old Mapbox) backends

@gitguardian
Copy link

gitguardian bot commented Sep 15, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
371130 Assigned Django Secret Key 634cae3 test_vectortiles/settings/init.py View secret
371130 Assigned Django Secret Key 7a07566 test_vectortiles/settings/init.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@686e906). Click here to learn what that means.

❗ Current head f699606 differs from pull request most recent head 1b78807. Consider uploading reports for the commit 1b78807 to get more accurate results

Files Patch % Lines
vectortiles/mixins.py 89.87% 8 Missing ⚠️
vectortiles/backends/python/__init__.py 28.57% 5 Missing ⚠️
vectortiles/rest_framework/views.py 70.00% 3 Missing ⚠️
vectortiles/backends/postgis/__init__.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage          ?   89.83%           
=========================================
  Files             ?       13           
  Lines             ?      305           
  Branches          ?        0           
=========================================
  Hits              ?      274           
  Misses            ?       31           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos marked this pull request as ready for review February 8, 2024 15:37
README.md Outdated Show resolved Hide resolved
README.md Outdated
...

# in your settings file
ALLOWED_HOSTS = [
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ALLOWED_HOSTS = [
ALLOWED_HOSTS = [

@@ -4,6 +4,11 @@ CHANGELOG
1.0.0.a1
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.0.0.a1
1.0.0-beta

@submarcos submarcos merged commit e00abb4 into master Feb 8, 2024
11 of 12 checks passed
@submarcos submarcos deleted the v1 branch February 8, 2024 15:43
** Breaking changes **

* Refactor PostGIS and Python (old named MapBox) backends usage. Use setting to set (default postgis)
* No DetailView anymore. As Tile can have many layers, declare VectorLayer on MTVView (one or many).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: MVTView

return layers_min_zoom if layers_min_zoom is not None else 0

def get_max_zoom(self):
"""Get tilejson manzoom from layers or self.man_zoom"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo :D 🕺

Copy link
Contributor

@StefanBrand StefanBrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still struggling to understand how I would implement the #44 usecase, but I'm just curious, no concrete application at the moment here. An example in the README can be useful. never mind, found it:

layer_classes = [FeatureVectorLayer]

In general, looks very good, great job to refactor the whole codebase!

@@ -17,101 +17,117 @@
pip install django-vectortiles
```

* Without any other option, use only vectortiles.postgis
* By default, postgis backend is enabled.
* Ensure you have psycopg2 set and installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note that psycopg is also supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Meta View to serve many vector tiles and generated tilejson at once
3 participants