Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme and doc #49

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Improve readme and doc #49

merged 6 commits into from
Sep 6, 2024

Conversation

submarcos
Copy link
Owner

No description provided.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (44b3ebc) 89.83% compared to head (cdc74ac) 88.60%.

Files Patch % Lines
vectortiles/mixins.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   89.83%   88.60%   -1.23%     
==========================================
  Files          13       13              
  Lines         305      316      +11     
==========================================
+ Hits          274      280       +6     
- Misses         31       36       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated
class CityCentroidVectorLayer(VectorLayer):
queryset = City.objects.annotate(
centroid=Centroid("geom"), # compute the city centroïd
area=Area("geom"), # compute the city centroïd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste left-over, should be "compute the city area"

README.md Outdated Show resolved Hide resolved
@submarcos submarcos marked this pull request as ready for review September 6, 2024 12:14
@submarcos submarcos merged commit 2a8f9c4 into master Sep 6, 2024
5 of 12 checks passed
@submarcos submarcos deleted the improve_readme_and_doc branch September 6, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants