Remove example E2E tests #1433
Merged
Remove example E2E tests #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests take 20 sec to complete due to an artificial 10 sec retry interval when verifying pods created. While we can reduce this interval to significantly speed up the tests, upon inspection, these 2 tests really don't add any value. The test description states "demonstrating the use of the test framework" but they don't really do that. One test creates pods in each cluster using the framework's generated namespace but that's really trivial usage of the framework. The other test merely lists pods in each cluster which doesn't even use the framework. There's plenty of other E2E tests that demonstrate the use of the framework. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr1433/tpantelis/rem_example_e2e |
sridhargaddam
approved these changes
Oct 21, 2023
skitt
approved these changes
Oct 23, 2023
|
🤖 Closed branches: [z_pr1433/tpantelis/rem_example_e2e] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests take 20 sec to complete due to an artificial 10 sec retry interval when verifying pods created. While we can reduce this interval to significantly speed up the tests, upon inspection, these 2 tests really don't add any value. The test description states "demonstrating the use of the test framework" but they don't really do that. One test creates pods in each cluster using the framework's generated namespace but that's really trivial usage of the framework. The other test merely lists pods in each cluster which doesn't even use the framework.
There's plenty of other E2E tests that demonstrate the use of the framework.