Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Fedora 41 #1728

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Bump to Fedora 41 #1728

merged 1 commit into from
Nov 12, 2024

Conversation

skitt
Copy link
Member

@skitt skitt commented Sep 26, 2024

This provides Go 1.23.

Compared to Fedora 40 images, this reduces the shipyard-dapper-base image size from 775MiB to 723MiB. Only installing the QEMU binaries that are needed further reduces that to 664MiB.

@submariner-bot
Copy link

🤖 Created branch: z_pr1728/skitt/fedora-41

@skitt skitt force-pushed the fedora-41 branch 2 times, most recently from dd3bbcb to f755e1e Compare September 26, 2024 14:48
@skitt skitt added lint-projects Lint consuming projects e2e-projects Run E2E tests in each consuming project unit-projects Run unit tests in consuming projects labels Sep 26, 2024
@skitt skitt marked this pull request as ready for review September 26, 2024 15:18
@skitt skitt added lint-projects Lint consuming projects unit-projects Run unit tests in consuming projects and removed lint-projects Lint consuming projects unit-projects Run unit tests in consuming projects labels Sep 26, 2024
@skitt
Copy link
Member Author

skitt commented Sep 26, 2024

Fedora 41 is still in beta so this might not be advisable right now but the risk should be low.

@tpantelis
Copy link
Contributor

Fedora 41 is still in beta so this might not be advisable right now but the risk should be low.

Do you feel confident to merge this for RC0 on Mon?

@skitt
Copy link
Member Author

skitt commented Sep 26, 2024

Fedora 41 is still in beta so this might not be advisable right now but the risk should be low.

Do you feel confident to merge this for RC0 on Mon?

If we don’t need Go 1.23 for rc0, probably not.

@skitt skitt marked this pull request as draft September 26, 2024 15:39
@tpantelis
Copy link
Contributor

Fedora 41 is still in beta so this might not be advisable right now but the risk should be low.

Do you feel confident to merge this for RC0 on Mon?

If we don’t need Go 1.23 for rc0, probably not.

We don't - let's hold off.

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 11, 2024
@dfarrell07 dfarrell07 removed the stale label Oct 15, 2024
@skitt skitt marked this pull request as ready for review October 29, 2024 17:59
@skitt
Copy link
Member Author

skitt commented Oct 29, 2024

Fedora 41 has been released.

@skitt
Bump to Fedora 41
a3cdc16 
This provides Go 1.23.

Compared to Fedora 40 images, this reduces the shipyard-dapper-base
image size from 775MiB to 723MiB. Only installing the QEMU binaries
that are needed further reduces that to 664MiB.

yq is no longer installed using Go, this drops it from tools.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt mentioned this pull request Nov 11, 2024
Closed
@skitt skitt merged commit 7635438 into submariner-io:devel Nov 12, 2024
63 checks passed
@submariner-bot
Copy link

🤖 Closed branches: [z_pr1728/skitt/fedora-41]

@skitt skitt deleted the fedora-41 branch November 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees
No one assigned
Labels
e2e-projects Run E2E tests in each consuming project lint-projects Lint consuming projects ready-to-test unit-projects Run unit tests in consuming projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skitt @submariner-bot @tpantelis @dfarrell07