Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add is_null for scalar types in testcase grammar #779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add is_null for scalar types in testcase grammar #779

wants to merge 2 commits into from

Conversation

scgkiran
Copy link
Contributor

No description provided.

EpsilonPrime
EpsilonPrime reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Could we add a test that exercises this behavior?

Perhaps:
add(1::i8?, 2::i8?) = 3::i8?

EpsilonPrime
EpsilonPrime reviewed Jan 23, 2025
View reviewed changes
grammar/FuncTestCaseParser.g4
;

literalList
: OBracket (literal (Comma literal)*)? CBracket
;

dataType
: scalarType
: scalarType isnull=QMark?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the grammar allows the question mark to ambiguously fall in either dataType or stringArg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the ambiguity, ? is always associated with type.
stringArg contains StringLiteral and stringType with optional ?

@scgkiran
Copy link
Contributor Author

Could we add a test that exercises this behavior?

Perhaps: add(1::i8?, 2::i8?) = 3::i8?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

@vbarua vbarua Awaiting requested review from vbarua vbarua is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scgkiran @EpsilonPrime