Add integration tests that ensure quickstart works #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstogner
reviewed
Sep 2, 2024
test/quickstart.sh
Outdated
| # Ensure the model count is 0 | ||
| curl -s -X GET "http://localhost:8000/openai/v1/models" | jq '. | length == 0' | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| # The previous skaffold step installed KubeAI using the helm chart. | |
| # By using the --reuse-values flag we can just append models to the previous install | |
| # while avoiding overriding the image that skaffold originally built and set in the first | |
| # install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple e2e test written in bash. This ensures that the steps in the README won't be broken by other PRs. More advanced e2e tests can be written in golang. The tests succeed in ~4-5 minutes depending on how fast the download of gemma 2b is.
In some cases the download may take longer than the timeout.