Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximum entries in polynomial interpolation approach #276

Merged
merged 9 commits into from
Mar 18, 2024

Conversation

sifnoc
Copy link
Member

@sifnoc sifnoc commented Mar 14, 2024

To address the issue #274

  • Added advice column in the range check circuit
  • Assign zero value from instance value
  • Replace terms polynomial encoding with polynomial interpolation

@sifnoc sifnoc force-pushed the v2-fix-maximum-entries branch from 1588dd5 to dbbbbb2 Compare March 14, 2024 14:41
@sifnoc sifnoc requested a review from alxkzmn March 14, 2024 14:55
@sifnoc sifnoc marked this pull request as ready for review March 14, 2024 14:55
let instance = meta.instance_column();
meta.enable_equality(instance);

let z0 = meta.advice_column();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like z0 is not used anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I quickly fixed! at c831f5d

Copy link
Contributor

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can merge after removing the unused z0 advice column. Thanks for cleaning up the naming!

Copy link
Contributor

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sifnoc sifnoc force-pushed the v2-fix-maximum-entries branch from 9e7cecc to 6289153 Compare March 15, 2024 11:41
@sifnoc sifnoc merged commit bbd2a5f into v2 Mar 18, 2024
6 checks passed
@sifnoc sifnoc deleted the v2-fix-maximum-entries branch March 18, 2024 04:30
alxkzmn added a commit that referenced this pull request Mar 27, 2024
* Removed MST approach, 'zk_prover' on v2

* updated README on contract

* Rename kzg_prover to prover

* Fix maximum entries in polynomial interpolation approach (#276)

* Add range check sufficiency explanation in the chip docs (#278)

---------

Co-authored-by: Alex Kuzmin <6849426+alxkzmn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants