-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maximum entries in polynomial interpolation approach #276
Conversation
…in_constant' method
1588dd5
to
dbbbbb2
Compare
kzg_prover/src/chips/range/tests.rs
Outdated
let instance = meta.instance_column(); | ||
meta.enable_equality(instance); | ||
|
||
let z0 = meta.advice_column(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like z0 is not used anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I quickly fixed! at c831f5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you can merge after removing the unused z0 advice column. Thanks for cleaning up the naming!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9e7cecc
to
6289153
Compare
* Removed MST approach, 'zk_prover' on v2 * updated README on contract * Rename kzg_prover to prover * Fix maximum entries in polynomial interpolation approach (#276) * Add range check sufficiency explanation in the chip docs (#278) --------- Co-authored-by: Alex Kuzmin <6849426+alxkzmn@users.noreply.github.com>
To address the issue #274
polynomial encoding
withpolynomial interpolation