Refactor SidePanel #2903
Open
Refactor SidePanel #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Size Change: +3.29 kB (+0.49%) Total Size: 676 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
feat/DSYS-878/remove-react-modal
branch
from
bd6ce6a to
762ceb9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2903 +/- ##
==========================================
+ Coverage 87.98% 88.11% +0.12%
==========================================
Files 227 221 -6
Lines 13088 12868 -220
Branches 1795 1781 -14
==========================================
- Hits 11515 11338 -177
+ Misses 1519 1477 -42
+ Partials 54 53 -1
|
sirineJ
force-pushed
the
feat/DSYS-878/remove-react-modal
branch
from
762ceb9 to
2843340
Compare
sirineJ
force-pushed
the
feat/DSYS-878/remove-react-modal
branch
from
2843340 to
714716c
Compare
connor-baer
requested changes
Jan 22, 2025
packages/circuit-ui/components/SidePanel/components/Header/Header.module.css
Show resolved
Hide resolved
connor-baer
requested changes
Jan 23, 2025
There was a problem hiding this comment.
I noticed you renamed a number of props, but I assume only the internal API has changed and the public API is unchanged, correct?
I spotted a bug when resizing the viewport from mobile to desktop while the side panel is open. The dialog remains positioned in the center of the viewport.
packages/circuit-ui/components/SidePanel/SidePanelContext.spec.tsx
Outdated
Show resolved
Hide resolved
sirineJ
force-pushed
the
feat/DSYS-878/remove-react-modal
branch
from
8b37d02 to
6b3c420
Compare
connor-baer
reviewed
Jan 24, 2025
There was a problem hiding this comment.
This file shouldn't be committed 😄
There was a problem hiding this comment.
The side panel's opening animation appears to be broken, it now appears instantly.
sirineJ
force-pushed
the
feat/DSYS-878/remove-react-modal
branch
from
4d0c3ee to
7fe7e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-878
Purpose
Refactor the SidePanel component to replace react-modal with the Dialog component. Remove the react-modal dependency.
Approach and changes
backButtonLabelreact-modalpackagepreventCloseprop into :preventOutsideClickClose,preventEscapeKeyCloseandhideCloseButton.Definition of done