Fix SetFunctionCall if has zero tools (#160)

sunshineplan · Dec 10, 2024 · 8675070 · 8675070
1 parent ac737ef
commit 8675070
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/ai_test.go b/ai_test.go
@@ -139,6 +139,10 @@ func testFunctionCall(t *testing.T, model string, c ai.AI) {
 		c.SetModel(model)
 	}
 	c.SetTemperature(0)
+	c.SetFunctionCall(nil, ai.FunctionCallingAuto)
+	if _, err := c.Chat(context.Background(), ai.Text("Which theaters in Mountain View show Barbie movie?")); err != nil {
+		t.Fatal(err)
+	}
 	movieChat := func(t *testing.T, s ai.Schema, fcm ai.FunctionCallingMode) {
 		movieTool := ai.Function{
 			Name:        "find_theaters",

diff --git a/anthropic/anthropic.go b/anthropic/anthropic.go
@@ -106,7 +106,10 @@ func (ai *Anthropic) wait(ctx context.Context) error {
 
 func (ai *Anthropic) SetModel(model string) { ai.model = model }
 func (a *Anthropic) SetFunctionCall(f []ai.Function, mode ai.FunctionCallingMode) {
-	a.tools = nil
+	if a.tools = nil; len(f) == 0 {
+		a.toolChoice = nil
+		return
+	}
 	for _, i := range f {
 		a.tools = append(a.tools, anthropic.ToolParam{
 			Name:        anthropic.String(i.Name),

diff --git a/chatgpt/chatgpt.go b/chatgpt/chatgpt.go
@@ -108,7 +108,10 @@ func (ai *ChatGPT) wait(ctx context.Context) error {
 
 func (ai *ChatGPT) SetModel(model string) { ai.model = model }
 func (chatgpt *ChatGPT) SetFunctionCall(f []ai.Function, mode ai.FunctionCallingMode) {
-	chatgpt.tools = nil
+	if chatgpt.tools = nil; len(f) == 0 {
+		chatgpt.toolChoice = nil
+		return
+	}
 	for _, i := range f {
 		var parameters shared.FunctionParameters
 		b, _ := json.Marshal(i.Parameters)

diff --git a/gemini/gemini.go b/gemini/gemini.go
@@ -108,6 +108,11 @@ func (ai *Gemini) SetModel(model string) {
 }
 
 func (gemini *Gemini) SetFunctionCall(f []ai.Function, mode ai.FunctionCallingMode) {
+	if len(f) == 0 {
+		gemini.model.Tools = nil
+		gemini.model.ToolConfig = nil
+		return
+	}
 	var declarations []*genai.FunctionDeclaration
 	for _, i := range f {
 		p, err := genaiProperties(i.Parameters.Properties)