Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling s3 protocol #595

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Dec 4, 2024

What kind of change does this PR introduce?

Feature

What is the new behavior?

Allow disabling the S3 protocol on a per-tenant basis as well as when running Storage in single tenant mode using S3_PROTOCOL_ENABLED=false

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12157065878

Details

  • 36 of 42 (85.71%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 77.85%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/s3/index.ts 8 10 80.0%
src/internal/database/tenant.ts 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
src/http/routes/s3/index.ts 2 87.94%
Totals Coverage Status
Change from base Build 12067007851: -0.009%
Covered Lines: 13963
Relevant Lines: 17791

💛 - Coveralls

@fenos fenos merged commit 77a456f into master Dec 4, 2024
1 check passed
@fenos fenos deleted the feat/allow-disabling-s3-protocol branch December 4, 2024 14:35
Copy link

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants