Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add async client #619

Merged
merged 4 commits into from
Nov 23, 2023
Merged

feat: add async client #619

merged 4 commits into from
Nov 23, 2023

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Add async client to the library

What is the current behavior?

Currently only supports sync client

What is the new behavior?

Add async client

Additional context

Add any other context or screenshots.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (f0dbe94) 70.00% compared to head (c34d5c6) 45.92%.

Files Patch % Lines
supabase/_async/client.py 0.00% 95 Missing ⚠️
supabase/_sync/client.py 68.42% 30 Missing ⚠️
supabase/client.py 0.00% 10 Missing ⚠️
supabase/_async/auth_client.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #619       +/-   ##
===========================================
- Coverage   70.00%   45.92%   -24.08%     
===========================================
  Files           9       13        +4     
  Lines         200      307      +107     
===========================================
+ Hits          140      141        +1     
- Misses         60      166      +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

supabase/_async/client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@silentworks silentworks force-pushed the silentworks/async-client branch from 14d3f9b to c34d5c6 Compare November 23, 2023 00:21
@silentworks silentworks merged commit ee64181 into main Nov 23, 2023
5 of 7 checks passed
@silentworks silentworks deleted the silentworks/async-client branch November 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants